Giter VIP home page Giter VIP logo

Comments (2)

aral avatar aral commented on August 23, 2024

Ah, I was confused by the wording, it does say to sign the hash, not the transaction but it can be misinterpreted:

When you generate a new hash for a transaction, sign it using the secret key

The it in “sign it” could refer to the hash (which it should) or to the transaction. Given that the latter implementation has a security implication, I feel we should be explicit here:

When you generate a new hash for a transaction, sign the hash using the secret key

I’ll issue a PR for that if that’s cool.

from learntocrypto.

emilbayes avatar emilbayes commented on August 23, 2024

Please do, this was the intention! :)

from learntocrypto.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.