Add `const` attribute to Schema about tapir HOT 10 CLOSED

There is const in the jsonschema that we use: https://github.com/softwaremill/sttp-apispec/blob/master/apispec-model/src/main/scala/sttp/apispec/Schema.scala#L55

I don't think we should be assing const to sttp.tapir.Schema. That's the high-level representaiton. Possibly, the translation between a tapir schema and an async api schema needs to be adjusted?

from tapir.

That's probably the place where the discriminators are generated:

from tapir.

I wonder if the way discriminators are defined for OpenAPI and AsyncAPI diverges? But hopefully we can generate something that works for both cases

from tapir.

There is const in the jsonschema that we use: https://github.com/softwaremill/sttp-apispec/blob/master/apispec-model/src/main/scala/sttp/apispec/Schema.scala#L55

True, I think it is not being set anywhere in the schema generation code, though.

I don't think we should be assing const to sttp.tapir.Schema. That's the high-level representaiton. Possibly, the translation between a tapir schema and an async api schema needs to be adjusted?

If I am not mistaken, currently OpenAPI and AsyncApi schemas are rendered in the same way, this leads to an illegal async api spec when using .withDiscriminator: #3754. So yes, it looks like a translation between a tapir schema and an async api schema needs to be adjusted.

from tapir.

I wonder if the way discriminators are defined for OpenAPI and AsyncAPI diverges? But hopefully we can generate something that works for both cases

AsyncApi does not support mapping for the discriminator, also discriminator must be a String. It looks like separate rendering paths might be needed - OpenApi conforms to JSON Schema Specification Draft 2020-12, AsyncApi does not.

from tapir.

Ah I see. Then I guess we'll need a flag for the TSchemaToASchema class to make this configurable

from tapir.

Ah I see. Then I guess we'll need a flag for the TSchemaToASchema class to make this configurable

What would be your suggestion for the flag? Discriminator-specific (we might stumble on other asyncapi/openapi incompatibilities in the future), or perhaps enum OpenApi/AsyncApi/JsonSchema? It seems that ASchema is only used for rendering to one of those specs.

from tapir.

Let's start with a simple Boolean flag if we want to generate mappings or consts for discriminators. If there are more such cases, we'll refactor. ASchema is an alias for the sttp-apispec Schema, I think it's used by both?

from tapir.

OK, let's roll with a Boolean flag. Yes, ASchema is used by both.

from tapir.

Closining for now, see #3765.

from tapir.