Giter VIP home page Giter VIP logo

Comments (7)

sol avatar sol commented on June 9, 2024 1

Sorry guys for the late reply. This is due to glob expansion. A fix may be somewhat fragile, that's why I was not excited to work on it so far.

I agree that in the case where no globs are used, hpack should not discard files if they don't exist. So I'm labeling this as a bug.

from hpack.

duog avatar duog commented on June 9, 2024 1

I am still interested in this though I don't currently have the time to commit to do it.
I think that we certainly do want a warning if a literal file does not exist.
I would think that a warning for a non-literal filename with no matches would be appropriate, but I can see cases where it would be superfluous.
I don't see any reason one wouldn't want this behaviour in all the sections you list.

from hpack.

sol avatar sol commented on June 9, 2024 1

@duog Thanks! We now keep literal files, even if non-existing and warn.

from hpack.

simonmichael avatar simonmichael commented on June 9, 2024

I just ran into this due an over-zealous clean script, and it caused some head-scratching. I think it would be better not to check for file existence here.

from hpack.

sol avatar sol commented on June 9, 2024

Blocked by Deewiant/glob#10.

from hpack.

sol avatar sol commented on June 9, 2024

Now that Deewiant/glob#10 is resolved we are in a better position to change what hpack does. So what exact behavior do we want?

  • If a file pattern is a literal file name, we want to keep it regardless of whether that file exists or not. Do we want a warning if the file does not exist?

  • If a file pattern is not a literal file name (contains wildcards), we expand it. If it does not match anything it's effectively discarded; currently we emit a warning if that happens. Do we want to keep that warning?

By default, the change would affect:

  • data-files
  • extra-source-files
  • c-sources
  • js-sources

from hpack.

sol avatar sol commented on June 9, 2024

@simonmichael @duog Are you still interested in this? If not, I'll close this issue.

from hpack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.