Comments (6)
lddw
is also incorrectly represented. It only takes one imm
, not two.
from rbpf.
I forgot rbpf has its own disassembler. Thanks for reporting these errors.
from rbpf.
lddw
is also incorrectly represented. It only takes oneimm
, not two.
I don't see two immediate operands in disassembler output.
from rbpf.
I mean lddw
is the only 16-byte instruction. It takes the imm
from two consecutive 8-bytes (see https://github.com/solana-labs/rbpf/blob/main/src/ebpf.rs#L554). The disassembly only takes one imm
.
from rbpf.
I mean
lddw
is the only 16-byte instruction. It takes theimm
from two consecutive 8-bytes (see https://github.com/solana-labs/rbpf/blob/main/src/ebpf.rs#L554). The disassembly only takes oneimm
.
yes, it's a 64-bit immediate value, and it is decoded from the 128-bits of the instruction code. There are no two immediates. Not all bits of the 128-bit instruction code are used. Can you give an example of code that was disassembled incorrectly?
from rbpf.
Wait. Sorry, I'm stupid. I didn't realise that augment_lddw_unchecked
had been applied prior to disassemble_instruction
. I think it disassembles correctly.
from rbpf.
Related Issues (20)
- The new ELF parser should use checked instead of saturating arithmetic
- elf: retrieve all dynamic metadata from the `.dynamic` table instead of requiring section headers
- JitCompiler::new() uses unwrap()
- Read only sections can overlap with the stack
- eBPF Standardization HOT 2
- Call target labels are not resolved in v0.2.38 HOT 4
- 32bit target support HOT 2
- ExceededMaxInstructions error message is confusing HOT 1
- Only require winapi on Windows
- git clone and cargo build gives error HOT 3
- elf_parser fails loading a valid ELF file HOT 8
- Call instruction transfers control to incorrect address HOT 4
- RBPF is killed by the OS while running a program HOT 2
- make btf instruction class an enum
- Attempt to negate with overflow in disassembler
- Warnings when compiling on macOS Arm
- Removing check SHIFT immediate number from verifier HOT 2
- assembler: register inconsistency HOT 3
- Interpreter LD_DW_IMM: add `!sbpf_version.disable_lddw()` checking
- type casting of rbpf HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rbpf.