Comments (3)
I think this is reasonable. Especially now that I've hoisted it and router levels are no more than index used to resolve nested Routes. I had different behavior since I constructed params differently. And now that I've hoisted it above as you say you can't access that context. Which is an interesting point on it's own as it means the router needs to be the lowest global context, if you want to be able to read from context above it. It also mean data functions are outside of the tree so they can't leverage any nested contexts. I realized this while implementing and I'm not sure there is much to do for it since to parallelize nested we need to do this. With this setup we can navigate to..
users/123/settings
and load both the user page
and the user settings sub page
in parallel while loading the data for both in parallel as well.
It does leave some questions on cascading data loads. Like what if the settings doesn't have enough from the url to know what data it needs, and needs to wait for the parents data to load first. In that case though I guess you wouldn't bother with a nested data component since you can't fetch in parallel anyway. Basically the view hierarchy can communicate to each other through props on the Route component or Context, but the data hierarchy has no similar way to communicate now that i've hoisted it. And in fact outside of a global store or props cannot communicate its results (nested contexts aren't available). These restrictions seem mostly fine but I feel like we can do better.
The answer might be related to this suggestion. Anything stored on the router itself would form a singleton context of sorts. But cleanup might be obvious. Anyway this is the sort of thing I'm thinking about.
from solid-router.
Ok done in 0.0.33. Also add NavLink
and isActive
from solid-router.
Aweesome! Thank you Ryan, that'll be really helpful!
from solid-router.
Related Issues (20)
- Crash when server function throws redirect and wrapped in createAsync HOT 3
- `window.location` holds incorrect value on initial client-side render HOT 1
- Actions called in onMount (or first run effect) are destroyed by start process, and do not receive values nor errors HOT 4
- In the new version, Route is imported as a type rather than a method. HOT 3
- Returning `never` from `redirect` function makes incorrect behavior HOT 6
- Absolute redirects inside `cache` are ignored if not called in `load`
- ErrorBoundary fallback renders twice HOT 2
- Drive letter is added to relative path on navigation when page is build on windows HOT 2
- NoJS mode is broken: initFromFlash cookie does not populate submission props HOT 1
- Ckeditor link trigger the router.
- Router fails to work properly on navigation HOT 3
- [Bug?]: submission.clear is not a function HOT 2
- Type issue: RouteLoadFunc generic cannot be inferred correctly
- Throwing or returning in redirect inside a cache function used in load results in error HOT 1
- Weird redirection when using Router and Route HOT 5
- 'use server' at top of file results in TypeError: action.apply is not a function HOT 3
- Solid Elements don't work with Server Actions HOT 2
- useParam() doesn't return a parameter if the value of it starts with a hash while using the HashRouter
- ErrorBoundary not working when using createAsync's accessor in createEffect HOT 4
- flaky cache in CatchAll Route after hydration HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from solid-router.