Comments (5)
Actually looking at it, it was intended to work. Looks like it was just a small mistake in the regex. Will get this fixed up shortly.
from solid-start.
Just to add that a workaround is to duplicate the routes folder structure for API calls, but not including any ()
type Route Group folders. It complicates things a lot when you've got a ton of routes, but at least it works.
Edit: Nope that actually doesn't work. The API route then works, but the initial route structure 500's with [h3] [unhandled] TypeError: Cannot read properties of undefined (reading '$GET')
Edit2: What does work is hardcoding matchAPIRoute(path, method)
in routes.js
to detect when the component path is being tested, and return instead of trying to find a match.
from solid-start.
Yeah in 0.5 I seperated the API route handling and simplified the matcher. However, I ended up reverting this separation later in the release which is why things don't look different even though they work completely different now. Given that I brought the routes back in I suppose it is fair to see if we can support the other syntax. I do caution in general that co-locating is a poor pattern here as we resolve all API routes before render routes, so things like catch alls won't work perhaps as you might expect when shared in the same scope as page routes. But I see very little reason not to allow them to work under things like route groups given where we landed.
from solid-start.
Cool thanks Ryan, just to add some more context, the scenario is like this:
For users to view their content, they go to: mydomain.com/viewer/userSlug
, to fetch a thumbnail for SEO, the meta tags use mydomain.com/viewer/userSlug/thumb
.
The /thumb
needs to be a GET API request as it just 301's to a jpg, and the /viewer/userSlug
route goes through a bunch of layouts/contexts using Route Groups. With the current setup, /thumb
simply doesn't work anymore and 404's.
from solid-start.
Edit, just made a new issue: #1470
from solid-start.
Related Issues (20)
- [Bug?]: client only doesn't work anymore for `props.children` HOT 6
- [Bug?]: Catch-all that starts with number after ellipsis in filename causes hydration errors in nested paths on dev HOT 1
- [Bug?]: Latest Vinxi (>= 0.3.11) causes layout shifts in dev HOT 4
- [Feature?]: Error Handling with solid-router HOT 8
- [Bug?]: Vite server config is being ignored HOT 4
- [Bug?]: Namespaces are completely stripped out of code HOT 4
- [Bug?]: error while importing module, related to `.` in path-name HOT 1
- [Bug?]: createHandler context only called once, renders nonce useless HOT 1
- [Bug?]: Client Only component displayed in app.tsx causes hydration errors HOT 1
- [Bug?]: No value attribute on CSR, but present in SSR HOT 5
- [Bug?]: Typescript error in tsconfig.json for new projects created with pnpm. HOT 1
- Redirect doesn't early exit component when loading from browser address bar HOT 3
- [Bug?]: Frequently generate app.config.timestamp_.js files when i change app.config.js file HOT 1
- [Bug?]: Flakey Hydration Error Key 0-0-0-0-0-0-0-5 HOT 4
- [Bug?]: Extend Solid config causes TS Errors HOT 2
- [Bug?]: Dev server fails to start when installing with new pnpm lockfiles HOT 3
- [Bug?]: The example in the docs doesn't seam to work. HOT 14
- [Bug?]: Issues with API/component routes in routes with parameters in RC1 HOT 3
- [Bug?]: RouteDefinition throw redirect not working HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from solid-start.