Comments (5)
I'm intentionally using version 1.1 of the Sonata bundle because for whatever reason the GoogleAuthenticator class is final in the 2.0 version, which makes it impossible to mock it in test cases.
This is not the reason for us to remove the final and there are other ways to write tests. We use final so people won't extend the classes which are not meant to be extended and make us unable to do changes to classes without a BC Breaks because there is someone that extended that class.
Still, that class should have an interface, and that would solve your "problem" with tests?
Not sure if we can introduce an interface without it being a BC Break, cc @greg0ire wdyt?
Since the class is final we probably can just add an interface and release a minor version with it.
from googleauthenticator.
That's what I assumed, thanks for confirmation.
If final answer is no, just close the issue.
ะฅะฒะฐะปะฐ!
from googleauthenticator.
I'm OK with adding an interface ๐
from googleauthenticator.
Me, too
@umpirsky are you willing to create a PR?
from googleauthenticator.
Done #111.
from googleauthenticator.
Related Issues (20)
- Google Charts API is deprecated and not available since March 19, 2019 HOT 7
- Fix Comment on Discrepancy HOT 2
- Sensitive information shared with external party HOT 8
- How can I create the secret code in random form? HOT 1
- Replay-protection HOT 3
- Code on App is different than code generated by $g->getcode(); HOT 6
- Fatal error: Uncaught Error: Interface 'Sonata\GoogleAuthenticator\GoogleAuthenticatorInterface' not found in HOT 2
- Bypass 2fa by rememberme cookie HOT 1
- PHP8 compatibility HOT 1
- PHP8? HOT 2
- Authentication with 60 seconds period not possible HOT 1
- Preview image HOT 1
- Security issue HOT 3
- Bad class api - GoogleAuthenticator HOT 1
- Have PHP and PowerShell create the same PIN HOT 1
- This bundle is abandoned // Looking for maintainers HOT 2
- Backup codes? HOT 2
- Code from app and getCode not match HOT 6
- Is still working? HOT 1
- Has OTOP verification just broken?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from googleauthenticator.