Giter VIP home page Giter VIP logo

Comments (5)

sonvister avatar sonvister commented on June 14, 2024

It was working before :) ...Binance is now sending an incompatible/invalid symbol ('ETC') in their list of symbols.

This has been patched in the latest source/release v0.2.0-alpha.6.

from binance.

benjaminthedonkey avatar benjaminthedonkey commented on June 14, 2024

@sonvister thanks for this project. It's pretty cool. I got the code and play around for a little bit. I end up adding a new attribute to the Symbol class. I needed it to calculate the correct quantity for an order. It's call 'stepSize' and it comes in the LOT_SIZE filter. If you are interested I can submit a push request.

from binance.

sonvister avatar sonvister commented on June 14, 2024

Thanks @benjaminthedonkey. I am glad my project is helpful and getting some use.

Regarding 'stepSize', I am aware of it and chose not to include that as an additional property of Symbol since it was and should be the same as 'minQty'. So, to avoid redundancy, I left it out since it didn't seem logical that they would ever differ. Perhaps when I get back around to implementing a more structured and complete ExchangeInfo I may refactor Symbol; certainly if they do take on different values. You could argue that the safer approach would be to add it assuming it will eventually be different (and that may have been your thoughts). But, I chose the minimalist approach (hoping for a simpler API) and will add on later if necessary.

Perhaps using Symbol.BaseMinQuantity will work in your case.

from binance.

benjaminthedonkey avatar benjaminthedonkey commented on June 14, 2024

Understood . I'm sure you arrived to that conclusion ( that should be the same as 'minQty' ) based on your knowledge, but for someone new to the API ( like me ) this is not obvious. The API documentation clearly talks about stepSize to calculate the lot size. I would add a comment to the code to clarify or perhaps add the property stepSize to the class Symbol and make it return minQty value for now. Just some ideas. Thanks again!

from binance.

sonvister avatar sonvister commented on June 14, 2024

Thanks for your feedback @benjaminthedonkey. I agree it was not clear that the values could be used interchangeably. I hope this second and more complete pass at integrating the exchange info into the Symbol object including the currently redundant increments (step size and tick size) is more useful and intuitive (0.2.0-alpha.9). I will be updating my documentation also.

from binance.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.