Giter VIP home page Giter VIP logo

Comments (5)

sophice avatar sophice commented on September 2, 2024

Thanks for the share link, I will investigate. I'm going to see if I can set up proper unit testing, to help make sure things like this don't happen. Too many scenarios to manually test well.

I'll put some thought in to the presentation of "current tier". I felt this was the clearest way to do it, but I'll think some more. I tend to look at the battle pass section in game, and on there the progress line shows the current tier you're working on, so that felt the most obvious to put. The "current tier you're working on". Hard to say what most people would prefer without a poll or something. Maybe just tweaking the labels on the fields would make it clearer... I'll finish working on the unit testing and then come back to that.

from ow2-battle-pass-calculator.

sophice avatar sophice commented on September 2, 2024

So I loaded up your link and it's not showing me the same thing that you are seeing. I see your projected finish as missing 35 tiers, and your expected finish as missing 2 tiers. You might have an outdated version of the page cached in your browser, try clearing your cache and see if you get a different result?

from ow2-battle-pass-calculator.

rufusw avatar rufusw commented on September 2, 2024

Thanks for taking a look at my link.

The bug only appears when the expected finish reaches 100% completion, so if you increase the tier to 24 today, it says finished in 4 more days. If you increase it to tier 34 it says 0 days to finish.
https://sophice.github.io/ow2-battle-pass-calculator/#t=34&x=1240&p=7&d=3&m=5&v=1212&w=3

To be sure I just tested in a different browser and its the same result.

About the current tier ambiguity - a small tweak to the label sounds best in my opinion.

from ow2-battle-pass-calculator.

sophice avatar sophice commented on September 2, 2024

I see now. I THINK I've fixed it, try now and let me know if it looks right.

from ow2-battle-pass-calculator.

rufusw avatar rufusw commented on September 2, 2024

Yes I think you fixed it, looks fine to me now. Thanks!

from ow2-battle-pass-calculator.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.