Comments (5)
Cc @jcastill and @mhradile at least.
AFAIK original plans were to keep the shortcut/redirectors for the sos-4.*
timeframe. While the planned change itself is sound, my gut feeling is users are not yet prepared, still thinking about "sosreport (tarball) is taken by sosreport (command)". We do have a warning text Please note the 'sosreport' command has been deprecated
but it is hard to say how many people read the leading text (or realize its implication). People usually run sosreport
, wait for the outcome and copy the generated tarball. So maybe we shall put such string (also) at the end of the stdout where it gets more attention as a heads up, now?
Also, what would be the justification for the redirectors drop - just "we have the legacy redirectors for a while"? Isn't better message "here we add another sos
subcommand (e.g. sos upload
) under the sos
umbrella and it is the good time to drop the redirectors"?
from sos.
from sos.
AFAIK original plans were to keep the shortcut/redirectors for the
sos-4.*
timeframe.
I mean, we only went to 4.x instead of continuing the 3.x line because of the new binary. I don't see anything on the horizon that would want us to move to a 5.x versioning scheme (also, just going to sidestep the entire versioning scheme debate minefield here). Software evolves and we should be mindful of backwards compatibility for sure, but we shouldn't be shackled to maintaining old entrypoints.
While the planned change itself is sound, my gut feeling is users are not yet prepared, still thinking about "sosreport (tarball) is taken by sosreport (command)".
It's been over 3 years at this point; how much preparation is realistically needed?
Beyond that we should want to encourage an understanding that sos
does more than "just" the report function. One of the easiest ways to do this is to have users notice "hey, report is a subcommand, what else can this thing do?"
We do have a warning text
Please note the 'sosreport' command has been deprecated
but it is hard to say how many people read the leading text (or realize its implication). People usually runsosreport
, wait for the outcome and copy the generated tarball. So maybe we shall put such string (also) at the end of the stdout where it gets more attention as a heads up, now?
I'd definitely be open to adding a footer message for a minor version cycle before we drop the redirectors.
Also, what would be the justification for the redirectors drop - just "we have the legacy redirectors for a while"? Isn't better message "here we add another
sos
subcommand (e.g.sos upload
) under thesos
umbrella and it is the good time to drop the redirectors"?
As I recall, sos upload
was shot down when I brought it up previously in an SST meeting - but less pedantically to your point of tying it to another subcommand being added...it'd be nice but I don't think we should marry the two. By that same token, if there are subcommands you/anyone think would be a useful addition let's get a discussion going on that separately from this one.
Our (old and nowhere near migrated) tests are definitely not ready.
I'm going to be politically nice here and not comment on this point.
from sos.
What about adding the text "Please note the 'sosreport' command has been deprecated" in 4.7, leave it for 4.8 (and perhaps expand it with a 'will be completely dropped in the next minor release', and drop redirectors in 4.9 (or even 4.10 if we consider that there will be 4.xx) ?
We have this documented in many places already, and two minor releases may give us enough time to finish whatever else is needed regarding communication.
Our (old and nowhere near migrated) tests are definitely not ready.
@mhradile we can discuss this, but hopefully two minor releases may give us enough time to plan for the change?
from sos.
I am ok having that explicit statement "sosreport command will be removed in the (next | 4.X) release" around the "sosreport has been generated at" text, and react accordingly :)
from sos.
Related Issues (20)
- [RFE] speedup journal export HOT 5
- [RFE] collect kubernetes informations for kubeadm installs HOT 2
- [ubuntu] snap causing issues on 18.04
- sos.conf options dont match cmdline options HOT 3
- Using maxage argument in PlugIn's add_copy_spec raises an exception
- There are no plugin to gater K8s/OCP rotated logs
- [snaps] when using `--all-logs` some command outputs will not be collected HOT 2
- An uncaught exception when add_copy_spec adds big files twice and reaches sizelimit HOT 2
- [RFE] Set a UserAgent for --upload-protocol s3 HOT 2
- [snap-workflow] snap workflow doesn't work due to snap/action-build with ubuntu 24.04
- sos spec file needs to remove python3-magic file under RH9 release HOT 9
- [RFE] add the output of “ps auxfwww” to the report HOT 2
- [RFE] Add some networking related command outputs HOT 3
- [sunbeam] sosreport is not obfuscating ceilometer secrets when running the sunbeam plugin
- [cleaner] periodic cleanup of mapping files.
- [MAC cleaner] too relaxed IPV6_REG_4HEX matching UUIDs HOT 7
- Missing documentation related to node, extra, presets file formats/examples HOT 4
- Enable "Require branches to be up to date before merging"
- [cleaner] keyword_map obfuscation is incremented when the same keyword is provided more then once.
- [processor] plugin timing out on turbostat HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sos.