Probable bugs in install_plugin.rb about elasticsearch HOT 9 CLOSED

The plugin installation support should make it easier, allowing you to set the plugins you wanna install in node configuration. I'll keep it in mind.

from elasticsearch.

@karmi Sorry for soliciting your time & help so shamelessly but not_if is a Chef thing and I can't test it via irb on my AWS instance so I can only ask for your help.

Here, have a look at the contents of the plugins directory:

$ ls /usr/local/elasticsearch-0.19.3/plugins/
cloud-aws  head

And then checkout the result of this chef-solo run:

$ time ssh -t $SSH_OPTIONS $HOST "sudo chef-solo -l debug --node-name elasticsearch-test-1 -j /tmp/run-3.json"
INFO: *** Chef 0.10.8 ***
INFO: Setting the run_list to ["recipe[elasticsearch::plugin_jetty]"] from JSON
DEBUG: Processing bash[/usr/local/bin/plugin -install sonian/elasticsearch-jetty/0.19.3] on elasticsearch-test-1
INFO: Processing bash[/usr/local/bin/plugin -install sonian/elasticsearch-jetty/0.19.3] action run (elasticsearch::plugin_jetty line 5)
DEBUG: Skipping bash[/usr/local/bin/plugin -install sonian/elasticsearch-jetty/0.19.3] due to not_if ruby block

I don't understand why the not_if block would cause this install to be skipped, do you?

from elasticsearch.

I edited the code to add some puts statements:

  Dir.entries("#{node.elasticsearch[:dir]}/elasticsearch-#{node.elasticsearch[:version]}/plugins/").any? do |plugin|
    begin
      puts params[:name]
      puts plugin
      puts params[:name].include? plugin
      params[:name].include? plugin
    rescue
      puts "why am in the recue block?"
      false
    end
  end

And the result that causes the skip is because of the current directory's "." being a part of the "."s in 0.19.3 as this shows:

sonian/elasticsearch-jetty/0.19.3
.
true

from elasticsearch.

@karmi Ok I've done something that makes it more robust for me, I would like to contribute back to your source with your permission ... BUT i'm not sure how to setup a selective pull request for your repo ... as the silly thing tries to push additional stuff you don't need as well (:

from elasticsearch.

Hello, dont' worry about that :), thanks for finding the bug. I have to reproduce it myself anyway, to better understand it.

from elasticsearch.

@pulkitsinghal Can you try to replicate the issue on the current master?

from elasticsearch.

It may take me a month or more to get to this :(

from elasticsearch.

Hello, the issue should be solved on current master.

from elasticsearch.

@karmi Thanks!

from elasticsearch.