breaking change: quotes around values disappeared from php.ini about php HOT 5 CLOSED

The breaking change was here: 58bcea4

I don't object to the change, but it definitely needs to warn users about it.

from php.

Ah, @jorhett you are right, I forgot about things like date.timezone needing quotes.

from php.

For anyone coming here for this issue, the reference PR is #89 and the first issue in #88

I added to the changelog here on Github, but at this point I can’t change the log that is on the Supermarket or that was sent out in the email from supermarket if you follow the cookbook there.

I had labeled this as a bug since it was breaking the use of error reporting, and it made sense to me that users could manually add quotes where needed. I didn’t even think about user defined directives since our array here is empty I didn’t have to make any changes other than merge the PR.

This was a major mistake on my part. I understand the idea of SemVer, and strive to follow it. This break in BC was definitely not intended and I am sorry for any issues this may have caused anyone.

from php.

Looks like this was addressed via the CHANGELOG update.

from php.

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from php.