Commented out run level + enable causes the Upstart conf to be regenerated at each run about redisio HOT 8 CLOSED

The reason for having the startup levels commented out by default is that you could install redis and not want to have it enabled on boot. The upstart provider will uncomment the line if you call the enable action on the service. It seems to me having it disabled on boot by default is the safer option.

Thoughts?

from redisio.

Sorry misunderstood the ticket at first. I see the issue. Not sure of a good way to avoid this really while staying with defaulting to the service being disabled.

from redisio.

I agree with the logic, but don't love the config file churn of disabling and re-enabling on each run. I suppose it's technically possible that the file could be modified by commenting out the line, then the chef run could fail before it's reenabled. Seems very unlikely, by possible.

Perhaps a better option is to have the cookbook set to startup by default (seems like a reasonable default to me, but YMMV) and use an attribute to toggle the enable or disable function?

from redisio.

I say startup as default because, when it comes to running a sever (vs. e.g. a workstation), service startup on boot seems to follow the principle of least surprise.

from redisio.

I've been trying to puzzle a good solution to this. Maybe it does just make sense to have it not commented out initially.

from redisio.

I think maybe we should stick to the (albeit, imho, not great) way Ubuntu starts on boot. This would follow the principle of least surprise for that distro.

from redisio.

Closing due to inactivity.

If this is still an issue please reopen or open another issue. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help!

Thanks,
Sous-Chefs

from redisio.

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from redisio.