Default settings "save" as empty string breaks install about redisio HOT 7 CLOSED

Whoops this should be a check for .nil and .empty or the documentation should be updated to say nil instead of empty string. Ill fix this ASAP.

from redisio.

Well, there's a difference between "nil", which gives you default values, and empty string (or whatever would be appropriate) to allow you to disable the values - would that be a correct interpretation of what's supposed to be allowed?

I originally tested using .empty, but that still doesn't allow one the option of disabling the values - instead, it's only giving you the defaults when using an empty string (just like the default of nil).

from redisio.

You know I hadn't even thought about that. I suppose the empty string should disable it and nil should be the default values. Although that does feel slightly wrong to me somehow. As long as its documented, no big deal.

from redisio.

I suppose passing an empty list could be a possible way? I agree with you, though - as long as it's documented, anything should work :)

from redisio.

Hello. Is it fixed now?

from redisio.

Sorry been a little underwater with work. I will try to have this fixed by end of week.

from redisio.

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from redisio.