Add `Tags` attribute to timeseries in the query response about go-wavefront HOT 5 CLOSED

@chengwang86

Yes, we'd be happy to accept a PR with this functionality. Thanks.

from go-wavefront.

@louism517

In addition, can I add two more features to my PR?

1. According to the API,

QueryResult {
warnings (string, optional): The warnings incurred by this query ,
name (string, optional): The name of this query ,
query (string, optional): The query used to obtain this result ,
timeseries (Array[Timeseries], optional),
stats (StatsModel, optional),
events (Array[QueryEvent], optional),
granularity (integer, optional): The granularity of the returned results, in seconds
}

I would like to add warnings as an attribute to the queryResponse struct https://github.com/spaceapegames/go-wavefront/blob/master/query.go#L72
This will be helpful for debugging purposes. For example, sometiimes the returned Timeseries is empty and the warnings tell you the reason, even if the response.statuscode is still 200 (query succeeded).

2. The Execute() function (https://github.com/spaceapegames/go-wavefront/blob/master/query.go#L127) doesn't check the response statuscode. I want to update this function so that it returns an error with the response message as a string if the statuscode is not 200.

from go-wavefront.

Those both sound like great ideas. Look forward to your PR.

from go-wavefront.

@louism517 Here is my PR #11

I just noticed that the http statuscode was already handled properly in client.go. So I didn't make any changes to the Execute() function.

from go-wavefront.

close it per PR #11

from go-wavefront.