Comments (11)
Like all FITS keywords.
from stwcs.
Like all FITS keywords.
No, this is different. This is not about wcsname
being the same as WCSNAME
but rather:
WCSNAME = SOME NAME
being the same as
WCSNAME = Some Name
or
WCSNAME = some name
from stwcs.
In other words, if we want to have only a single Alt WCS with a given WCSNAME, should the following be allowed or not:
WCSNAMEA=Some Name
WCSNAMEB=SOME NAME
WCSNAMEC=some name
?
from stwcs.
Oh, you are asking about the value. There's no convention.
from stwcs.
Current code treats WCSNAME values as case-insensitive for the purpose of identifying corresponding WCS keys. Should is this how we want to have WCS names be when they are compared?
from stwcs.
There's no convention.
This suggests that the comparison should not be case-insensitive, i.e., name1
should be considered distinct from NAME1
, right?
from stwcs.
Treating WCSNAME values as case-insensitive makes it easier for the user to see that there are differences in the WCSs. It would be immensely confusing (as if it isn't already confusing enough) to explain to a user why a WCS named 'IDC_a123458bq-hsc30' is not the same as 'IDC_a123458bq-HSC30' since both reference 'HSC30'. Besides, users are already used to FITS keywords being case-insensitive, so simplifying the treatment of alternate WCSs by making them case-insensitive seems to be consistent with FITS. Therefore, it would be the most user-friendly, in my opinion, to keep WCSNAME as case-insensitive.
from stwcs.
But why would our software sometimes write 'IDC_a123458bq-hsc30'
and sometimes 'IDC_a123458bq-HSC30'
? I think the solution to this question now should be based on whether our existing software mixes cases when writing WCS names.
from stwcs.
I would not want to try to second-guess how these situations arise. However, users can provide a list of catalog names as an input parameter to the alignment code which would then get used to generate these names. If they provided lower-case one time and upper-case another (interactively, without thinking), they would end up with mixed cases as separate WCSs even though they may be identical. So, there are ways in which the user can cause this situation and make having WCSNAME be treated as case-insensitive be useful.
from stwcs.
Thanks!
from stwcs.
@stsci-hack But then there is code that is case sensitive, like here:
stwcs/stwcs/wcsutil/wcscorr.py
Lines 311 to 315 in 4a57476
It just seems that there is inconsistency in treating WCS names.
from stwcs.
Related Issues (20)
- TST: Remove flake8 check from allowed failures
- Change astrometry database update HOT 1
- Fix order of WCSs applied to image HOT 3
- Some keywords are not restored properly in headerlet.restore_from_headerlet
- WCS key that is a space should be converted to empty string before appending to keywords HOT 1
- Why is PC matrix multiplied by cdelt1 to get CD matrix
- Applying updatewcs with use_db=True multiple times results in multiple alternative WCSes HOT 1
- Wrong WCS being archived when applying updatewcs with use_db=True multiple times HOT 4
- Strange code in altwcs HOT 7
- _restore() overwrites archived WCS CTYPE HOT 3
- convertAltWCS and archiveWCS should not archive some non-altwcs specific keywords HOT 1
- When restoring from altwcs 'O', TDDALPHA is not reset HOT 1
- altwcs now causes pipeline software to crash HOT 5
- Should updatewcs overwrite OPUS WCS? HOT 3
- Automatic PyPI publication enabled HOT 1
- Applying a headerlet should remove all alternate WCSs if distortions are different HOT 1
- Compute new a priori WCS for updated IDCTAB in updatewcs HOT 1
- wcskey not properly propagated in tweakback? HOT 1
- Accommodating scalar promotion in Numpy 2.0 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stwcs.