Comments (5)
Also some bug with setting the detector is supposed to auto change the pixel scale but didnt...
from webbpsf.
OK, this is because setting the image_mask
attribute to "MASK335R" then invokes the code in NIRCam._update_aperturename()
which currently is written to assume MASK335R is only ever used with LW, and so on.
There's a one-line fix for this in setup_sim_to_match_file
to reset the aperture name after changing the image mask, which I'll do now.
But this makes me realize that it may no longer be useful or appropriate to have setting the image mask automatically switch to the nominal detector. For now I think we should not change the auto detector switching since that would be not back incompatible, but this could be discussed in the future.
from webbpsf.
I just wanted to mention setup_sim_to_match_file issue, #726, which is more related with adding addition per-instrument checks when selecting the right pupil.
from webbpsf.
@obi-wan76 can you give me specific filenames of observed data files that have the issues in #726? I can perhaps fold in fixes for those into this PR, but it would help to have test files to validate them on
from webbpsf.
When the pupil is not a mask, then the filter is not set correctly. For example, any of our sensing observations, e.g., jw02726477001_02102_00001_nrca3_cal.fits, simulate an in-focus PSF F212N instead of the WL. Other combinations would be, pupil+filter = F164N+F150W2 that set the simulation with filter F150W2 instead of F164N. I think when the pupil is not MASK then set the filter as the pupil.
The other issue is setting the observation when pupil = MASKBAR inside the image header because there is no MASKBAR in webbpsf. So, it need to choose between MASKSWB and MASKLWB depending on the filter. For example, jw01538048001_03103_00001_nrca4_cal.fits.
from webbpsf.
Related Issues (20)
- Add some more per-instrument specializations in setup_sim_to_match_file HOT 3
- UnboundLocalError: local variable 'rms_label' referenced before assignment HOT 1
- Efficiency improvement for webbpsf.trending.monthly_trending_plot()
- Encircled Energy Y axis label is cut off from the webbpsf.trending.monthly_trending_plot output PDF. HOT 1
- Add detector effects as default in the oversampled extension HOT 9
- Testing against numpy 2.0 and scalar representation changes HOT 1
- setup_sim_to_match_data documentation improvement
- Issue with convolution over pixel using astropy.convolution.Box2DKernel? HOT 4
- Read/load saved PSF grid? HOT 5
- MIRI cruciform detector effects not in Read the Docs HOT 2
- photutils GriddedPSFModel now supports different oversampling in each dimension HOT 1
- Improvements in MIRI LRS instrument model HOT 2
- AttributeError: 'MIRI' object has no attribute 'load_wss_opd_by_date' HOT 4
- Use consistent Time objects in trending.py
- PSF model worse for brightsky detector HOT 3
- setup_sim_to_match_file: Not properly reading NIRCam F323N? HOT 4
- Release 1.3 roadmap HOT 1
- NIRSpec NRS1 and NRS2 PSF creation have very different runtimes HOT 1
- setup_sim_to_match_file: F323N returns NRCA5 for NRCB5 module HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webbpsf.