Comments (2)
As mentioned in the README, I'm only implementing stuff that I need for my server (SparklyPower). The fork is public, sure, but I don't want to maintain a huge fork with features that I don't need, which makes updating my own server hard.
I only add patches from other performance forks (Pufferfish, DivineMC, Mirai, etc) if I know they are fixing a performance bottleneck that I have (or something that someone else can prove is a performance bottleneck) in my server. In fact, I have already combed thru Pufferfish's patches before and I have seen that SOME of their patches are half implemented, or affect server performance, so I won't copy all Pufferfish patches for SparklyPaper: https://github.com/SparklyPower/SparklyPaper/blob/ver/1.20.2/docs/BORKED_PATCHES.md
That doesn't mean that all Pufferfish's patches are bad, I have already borrowed some of their patches, like this one, but that's because I have already profiled my own server and seen that this does fix a performance painpoint: https://github.com/SparklyPower/SparklyPaper/blob/ver/1.20.2/patches/server/0003-Optimize-entity-coordinate-key.patch
Another thing that I don't like is that a lot of these performance patches from other forks do not add any kind of explanation about why they did it that way, what does it impact, how much mspt the code was using before the optimization... so on and so forth, so it is a blind guess about what the patch is actually optimizing and if it does improve performance at all. (Compare that to SparklyPaper's patches, where I do try to add an explanation for each patch in the patch itself and in the project's README)
I don't need the things that Purpur adds, so it would be new stuff to maintain that I don't need for SparklyPower.
What I recommend doing is that, if you have something that you really need from other forks, the best way to do it is to fork SparklyPaper and add your own patches on top of it.
from sparklypaper.
OK, I see. Thanks a lot❤
from sparklypaper.
Related Issues (10)
- I need a hint on how the kernel works HOT 1
- Redstone shinanigans with non alternate-current HOT 9
- more explanation HOT 1
- Very good HOT 1
- Exception ticking world HOT 3
- Inventory that was created at HOT 10
- log of respawning player HOT 2
- feature request: giant ai HOT 3
- Exception related to portals in The End HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sparklypaper.