FR: Dockerize about starlink-grpc-tools HOT 8 CLOSED

I'm not sure there is enough here to merit a Docker container, but if you think it would be useful, by all means, go ahead and implement.

One thing to note, though: I would consider the files generated by the protoc commands I pasted in the README to be derived from SpaceX copyrighted works, so unless and until SpaceX publishes the relevant .proto files with license terms that allow for redistribution, I will not personally be releasing a Docker image that includes those generated files.

from starlink-grpc-tools.

I think grabbing the protoset and deriving the proto's can be done as part of the container's runtime initialization and not the build avoiding this proprietary works issue. And yes, the request was more useful to me and would share if I did tackle it. The work done so far is awesome! Cheers!

from starlink-grpc-tools.

OK, that sounds good. I'm going to leave this one with you, as I have no direct experience with Docker myself.

from starlink-grpc-tools.

OK, hoping to get some cycles in-in the evenings this week, fingers crossed!

from starlink-grpc-tools.

FYI: I just pulled in a little code reorganization in preparation for adding a few more script variants. As a result, you will probably have to package up the starlink_grpc.py and/or starlink_json.py modules now, depending on which scripts you're targeting.

I'm not super happy with the module naming, and pylint really seems to hate my script naming conventions, but it works for now.

from starlink-grpc-tools.

FYI - In looking at recent changes I am going to pivot and make the container more generic to just being capable of running the python scripts generically with the necessary dependencies.

from starlink-grpc-tools.

I think the docker container will freeze here as it is just a generic host now regardless of the script being ran. Focus would move to allowing the scripts to loop and consume environment vars in order to make them docker-friendly. Suggest closing this issue.

from starlink-grpc-tools.

I concur, but I'll leave it up to you as you opened it and did the work on it.

from starlink-grpc-tools.