Giter VIP home page Giter VIP logo

Comments (3)

SpartanJ avatar SpartanJ commented on July 17, 2024

Original comment by Martín Lucas Golini (Bitbucket: SpartanJ, GitHub: SpartanJ).


You're right! Thanks for reporting it.
The mThread->wait(); wasn't even needed, the Thread destructor calls always to wait. So efSAFE_DELETE( mThread ); is enough.

I'm curious about the changes in efsw.h:
https://bitbucket.org/sepul/efsw/commits/ca34370fd2806afa1fdb8a1f134fee912a5d7992#chg-include/efsw/efsw.h
Did you have any problem? Because this was a merge from a contributor.

Regarding the vs2012 project file it's not necessary, since premake4 can generate the vs2012 project ( i'm using the vs project generate by premake, so it's working fine ). You just need to use the premake4 from the dev branch.

from efsw.

SpartanJ avatar SpartanJ commented on July 17, 2024

Original comment by Martín Lucas Golini (Bitbucket: SpartanJ, GitHub: SpartanJ).


Fixed issue #9

from efsw.

SpartanJ avatar SpartanJ commented on July 17, 2024

Original comment by Sepehr Taghdisian (Bitbucket: sepul, GitHub: sepul).


No, I haven't done any changes to efsw.h , just a very minor style change, I put EFSW_API at the beginning of the function declarations.

thanks, and keep up the good work

from efsw.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.