Giter VIP home page Giter VIP logo

Comments (5)

laurencei avatar laurencei commented on June 19, 2024 1

@patrickbrouwers - done.

from laravel-nova-excel.

laurencei avatar laurencei commented on June 19, 2024

Yep - I've just run into this exact same issue.

(new DownloadExcel)->only('id', 'example', 'other')

If example column is blank, then other column data ends up in example column.

from laravel-nova-excel.

laurencei avatar laurencei commented on June 19, 2024

So following on from what @jfeid said - if you make this change, it seems to be fix the issue:

        foreach (array_diff($only, array_keys($row)) as $attribute) {
            if ($model->{$attribute}) {
                $row[$attribute] = $model->{$attribute};
            }
+         else {
+               $row[$attribute] = '';
+         }
        }

I'm just not sure of any side effects of that? It seems to solve it for me...?

from laravel-nova-excel.

patrickbrouwers avatar patrickbrouwers commented on June 19, 2024

Can you PR that.

from laravel-nova-excel.

patrickbrouwers avatar patrickbrouwers commented on June 19, 2024

Fixed in latest release. Thanks @laurencei for the PR.

from laravel-nova-excel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.