Comments (3)
We'll handle this further in #20
from laravel-demo-mode.
hello guys,
I do not want to rush around, but .. The fallback added in #20 works even if demo-mode.enabled
is false
; which I guess should not be wanted behaviour ..
So, if the demoMode is disabled, 404 response results in redirect to demo-mode.redirect_unauthorized_users_to_url
It can be solved by adding a condition to DemoModeServiceProvider.php
like:
if (config('demo-mode.enabled')) {
$router->fallback('\Spatie\DemoMode\DemoModeController@catchFallback');
}
or rewrite logic of DemoModeController::catchFallback()
as it does not take in account disabled demoMode.
Thank you for all what you do.
from laravel-demo-mode.
@jankremlacek Thanks for reporting this, we'll take care of this soon.
from laravel-demo-mode.
Related Issues (12)
- Fork for PHP 5.6
- Auto-Registering Middleware? HOT 1
- Master needs to be tagged HOT 1
- Add support for IP addresses
- Too many redirect error HOT 1
- Request: Option to not allow authenticated users access HOT 2
- Redundant method HOT 3
- Demo url Accessable by logged in user HOT 2
- PHP 8 support HOT 1
- Support for Laravel 9 HOT 3
- [5.3] Demo mode is not compatible with `artisan route:cache` HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from laravel-demo-mode.