Adding Translatable to new Panel doesn't work about nova-translatable HOT 7 CLOSED

I think the filter @xPhantomNL mentioned not only filters but also merges the field data to the original fields wrapped by Translatable and thus the panel information is copied over to the original field and removed from Translatable field.

Removing lines 192 & 193, as in below, fixes the issue. I'd create a PR but I'm not sure how to patch this without breaking backward compatibility.

class Translatable extends MergeValue
{
    // ....
    protected function createTranslatedField(Field $originalField, string $locale): Field
    {
        // ....
        $translatedField
            ->resolveUsing(function ($value, Model $model) use ($translatedField, $locale, $originalAttribute) {
                $translatedField->attribute = 'translations_'.$originalAttribute.'_'.$locale;
//                $translatedField->panel = $this->panel;
//                $translatedField->assignedPanel = $this->assignedPanel;

                return $model->translations[$originalAttribute][$locale] ?? '';
            });

from nova-translatable.

This is still a problem, I opened a PR #99

from nova-translatable.

Changes made in #77 don't seem to do the trick anymore.

from nova-translatable.

Combining a Nova field and a Translatable field into the same new Panel results in the Nova field showing in the new Panel and the Translatable field showing in the main Panel.

from nova-translatable.

Running into this issue as well, any update or a workaround?

Downgrading Nova to 4.21.0 does seem to work on my end, so whatever was done in 4.22.0 breaks this package.

After some further inspection, in Nova 4.22 they're using the ConditionallyLoadsAttributes trait, which has a filter method (vendor/laravel/nova/src/Panel.php:125). That eventually leads to breaking the creation of new panels per locale.

from nova-translatable.

I'd accept a PR that fixes this.

from nova-translatable.

Dear contributor,

because this issue seems to be inactive for quite some time now, I've automatically closed it. If you feel this issue deserves some attention from my human colleagues feel free to reopen it.

from nova-translatable.