Giter VIP home page Giter VIP logo

Comments (12)

gdower avatar gdower commented on August 18, 2024

I also noticed in Firefox that sometimes after triggering an alt shortcut (like alt+o), when hitting the browser back button after triggering the alt+o shortcut, if you click alt again by itself with no other keys pressed it would re-trigger the last called alt+o shortcut. I'm also testing it on Chromium 126.0.6478.126 (Official Build) Arch Linux (64-bit) and it does the same behavior, so maybe it is a TaxonWorks bug.

On Chromium all the shortcuts work except alt+d (highlights URL in location bar), alt+f (opens browser hamburger menu), and these hotkeys all seem to trigger nothing in the browser or TW: alt+l, alt+s, alt+m, alt+c, alt+shift+l. Some of the other shortcuts that do work, sometimes don't work and I'm not sure yet what causes the inconsistent behavior.

Sometimes a bunch of the alt shortcuts stop working until I reload the edit nomenclature page, so it seems to be a conflict between the browser binding shortcuts and TW binding shortcuts.

from taxonworks.

gdower avatar gdower commented on August 18, 2024

I found that you can do page-specific Firefox permissions including allowing overriding keyboard shortcuts but most of the shortcuts still don't work and still trigger the Firefox alt menus:

image

I found an actual workaround that works.

In Firefox about:config set these keys:

ui.key.menuAccessKeyFocuses = false
ui.key.menuAccessKey = 0

That fixes all hotkeys except alt+l and alt+e and this likely TW bug still exists:

I also noticed in Firefox that sometimes after triggering an alt shortcut (like alt+o), when hitting the browser back button after triggering the alt+o shortcut, if you click alt again by itself with no other keys pressed it would re-trigger the last called alt+o shortcut. I'm also testing it on Chromium 126.0.6478.126 (Official Build) Arch Linux (64-bit) and it does the same behavior, so maybe it is a TaxonWorks bug.

from taxonworks.

gdower avatar gdower commented on August 18, 2024

alt+e works at the species group level. So it's just alt+l (clone taxon name) that doesn't work after disabling the Firefox alt shortcuts.

from taxonworks.

jlpereira avatar jlpereira commented on August 18, 2024

I'm going to prevent default behavior for these events

from taxonworks.

jlpereira avatar jlpereira commented on August 18, 2024

@gdower pushed changes for New taxon name, let me know if it works.

from taxonworks.

gdower avatar gdower commented on August 18, 2024

@debpaul helped test this on Windows. The back button alt bug is reproducible on Windows. Almost all of the TW hotkeys work on Windows (except alt+l clone taxon name) but they also almost always also trigger opening the Firefox menus which may discourage use of the hotkeys by Windows users. Although perhaps the solution is to just document the above about:config workaround because the power users that are using hotkeys will probably be comfortable with modifying keys in about:config (unless they routinely use the Firefox alt key shortcuts to access the browser menus).

from taxonworks.

jlpereira avatar jlpereira commented on August 18, 2024

Did she test it on local env after pull last commit? or sandbox/production?

from taxonworks.

gdower avatar gdower commented on August 18, 2024

It was on sandbox

from taxonworks.

jlpereira avatar jlpereira commented on August 18, 2024

I was able to replicate it on Windows using FF Development edition , but after last commit it seems to work now.

from taxonworks.

gdower avatar gdower commented on August 18, 2024

So there's 2 hotkey bugs.

  1. Do you want steps to reproduce the back button alt bug or does what I put above make sense?
  2. After disabling the Firefox alt shortcuts, the only other bug is alt+l not cloning a taxon name.

I'll test the development branch locally.

from taxonworks.

jlpereira avatar jlpereira commented on August 18, 2024

I will check alt+l

from taxonworks.

gdower avatar gdower commented on August 18, 2024

Awesome, you fixed the alt browser back button bug! alt+l doesn't work though.

from taxonworks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.