Bug: The new 2.16 category naming implementation needs alignment about speckle-sharp HOT 5 CLOSED

Thanks for flagging this Martin!
Seems to have been an involuntary consequence of our rework on categories. We'll make sure it's addresses before the stable release.

cc @paloknapo @AlanRynne

from speckle-sharp.

Thanks for flagging this Martin!
Seems to have been an involuntary consequence of our rework on categories. We'll make sure it's addresses before the stable release.

cc @paloknapo @AlanRynne

from speckle-sharp.

Hey @martinromby my understanding is that the strings sent in 2.15 use the display value of the Category field, which is localized.
How are you currently handling categories in other languages?

from speckle-sharp.

Hi @martinromby , to give you more context this misalignment was introduced because we've (1) refactored how we were previously sending category values with a new list of RevitCategory enums for better internal alignment and (2) we are now using the category display name for our Collection class while using the enum value for object category property values.

Would changing the Collection name to match the object category property values solve your misalignment issue, eg using StructuralColumns instead of Structural Columns for both the Collection name and the object category value?

from speckle-sharp.

Hi @clairekuang and @teocomi
Thanks for taking time out of your retreat to get back to me on this. :)

Hey @martinromby my understanding is that the strings sent in 2.15 use the display value of the Category field, which is localized. How are you currently handling categories in other languages?

We haven't run into these issues just yet. But this PR smoothens those bums - thanks! 🙌

Just for reference:
Commit with 2.15.2 version - with DEU localization (localized category naming):
https://speckle.xyz/streams/8bfb3033d8/commits/059d931656

Commit with 2.16.0-rc3 version - with DEU localization (standardised category naming):
https://speckle.xyz/streams/8bfb3033d8/commits/bc4f108228

Hi @martinromby , to give you more context this misalignment was introduced because we've (1) refactored how we were previously sending category values with a new list of RevitCategory enums for better internal alignment and (2) we are now using the category display name for our Collection class while using the enum value for object category property values.

Would changing the Collection name to match the object category property values solve your misalignment issue, eg using StructuralColumns instead of Structural Columns for both the Collection name and the object category value?

Ahh - I see. At the moment we use the object category property values, but I agree that the ENUM lists are a better implementation and we'll change our whitelisted categories accordingly.
I'll leave the Collection naming up to you, but I weigh towards some sort of naming alignment between Collection and object.

from speckle-sharp.