Comments (2)
Can you provide an unit test for this?
This would help understanding the problem and having a definition of "done"
Similar bug in the past #1400
My issue probably caused this change 😅
I guess there is no absolute right answer, and if it is it is harder to do than it may first look like
from spectre.console.
I introduced the bug @JKamsker, unfortunately. I knew it was a breaking change, and flagged it as such, but I think the change in functionality is probably now best described as a regression. I'll add this to my stack to review/address.
And
FYI. I've submitted the PR above to revert this to existing behaviour @JKamsker
Background
Apologies for creating this problem. The above issue description is exactly correct, we changed this behaviour between 0.47 and 0.48.
It had worked as per the current 0.48 earlier than 0.47, then I did some refactoring, changed it to the behaviour in 0.47, flagged it as a breaking change (thinking it was fine to make breaking changes, if warranted, as we are still < version 1.0), which was accepted by the maintainer team and merged.
Then we found a number of unhappy users of spectre.console (because we broke their apps), and so on further consideration, we reverted the change. Unfortunately, I doubt we'd be looking to revert it once again.
from spectre.console.
Related Issues (20)
- Allow AnsiConsoleFactory to use a user provided IAnsiConsoleInput HOT 1
- Task< SomeReturnInfoClass > state = _app.RunAsyncWithState(args)
- Update table documentation example demonstrating cell borders
- AddDelegate produces a MissingMethodException HOT 5
- Allow option to clear text after textprompt is answered
- Top Issues Dashboard
- Remove System.Memory dependency from net 6+ HOT 4
- Implement fixed-size log-text area for `ProgressTask` HOT 5
- Progress update causes heavy flickering (regression from 0.47.0 to 0.48.0) HOT 2
- Release a new version with support for InterceptResult as described in documentation HOT 1
- Sixlabors ImageSharp 3.X?
- Add interactive input fields HOT 1
- Built-in parameter `--version` conflicts with existing one HOT 9
- `ExplainCommand+Settings` ctor fails `ServiceProvider.ValidateService` HOT 1
- Bad rendering for table live display / hidden table headers / no border and forced refresh
- Search doesn't work properly in selection prompts HOT 1
- Add paging function to selection prompt
- Fill entire background with custom color
- Unable to redirect output to file HOT 1
- More control over output - padding HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spectre.console.