Giter VIP home page Giter VIP logo

Comments (7)

spencermountain avatar spencermountain commented on September 15, 2024 1

thank you. Yup - I will release a hotfix this afternoon.
appreciate the help.

from spacetime.

eaarranz avatar eaarranz commented on September 15, 2024 1

I will open a bug to Apple as feedback for Sonoma; at least we'll know if it's something planned or needs fixing on their side.

from spacetime.

eaarranz avatar eaarranz commented on September 15, 2024

We may help you with the implementation if you consider that it should be fixed ;) Maybe you should allow the same approach that you use at timezones-soft in the lookupTz function or add cet and cest as aliases, but we should explore if it happens elsewhere.

from spacetime.

spencermountain avatar spencermountain commented on September 15, 2024

oh my gosh - thank you for the heads-up.
Is this documented anywhere? Yeah, I'm happy to fix this asap.
Yep, at minimum we can add a guard to prevent the runtime error.
Please let me know if you can dig anything up about this change. I can't believe they're returning non-IANAs.
oof!
thank you.

from spacetime.

eaarranz avatar eaarranz commented on September 15, 2024

Since the heads up from one of our customers, we have been trying to reproduce it, and we were able to reproduce it with the last beta updating one of our laptops. At least here where we were getting 'Europe/Madrid', we are getting 'cet'; configuring the timezone manually to 'Europe/Madrid' does not change it back to 'Europe/Madrid' and keeps returning 'cet.'.

We did not find any documentation regarding it... But we are kind of lost on where Apple tracks these types of changes.

Since you have the aliases, maybe we can extend them to include cet, met, eet and wet and use them to check if the returned value of Intl.DateTimeFormat().resolvedOptions().timeZone is an alias and return the IANA value of them.

from spacetime.

spencermountain avatar spencermountain commented on September 15, 2024

ok - released a fix for this as 7.4.7 - but would love some help testing it against any variants of this.

Yeah - turns-out there's even-weirder responses than 'CET' from the Intl api, apparently you can get the result 'Factory'. No idea how, but it appears in:

Intl.supportedValuesOf('timeZone')

I added a test for the Node 18, and Firefox results, but I'm sure there's more to be found. I aliased them to whatever it said in wikipedia. - but please let me know if I've done something foolish. There's always a good chance of this.
cheers

from spacetime.

eaarranz avatar eaarranz commented on September 15, 2024

I'll take a look at both the supported values that I get on Chrome and the values that we get on Sonoma.

from spacetime.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.