Проблема с транзакциями about database HOT 6 CLOSED

Предположительно поправили в последнем релизе.

from database.

Возможно пофикшено в #66

from database.

Possibly fixed in # 66

I think so. I haven't had this issue in a while. This was also suggested in #62 (comment)

from database.

I'm getting the same exception on SPV0 not sure if it's related. It's coming from spiral/migrations when running migrations.

while (($migration = $migrator->run()) !== null) {
    $output->writeln("+ {$migration->getState()->getName()}");
}

PDOException: SQLSTATE[42000]: Syntax error or access violation: 1305 SAVEPOINT SVP0 does not exist

I think this is running execute on a CREATE TABLE statement that implicitly commits the transaction. Then when you try to commit the transaction it throws an exception that is caught and then the rollBack is called and dose not have a save point to go back to. The below snippet is from https://github.com/spiral/database/blob/master/src/Database.php#L244-L254 and if you wrap the commit in a try you get "There is no active transaction"

try {
    $result = $callback($this);
-   $this->commit();
+   try {
+       $this->commit();
+   } catch (Throwable $e) {
+       $e->getMessage(); // "There is no active transaction"
+   }

    return $result;
} catch (Throwable $e) {
    $this->rollBack();
    throw $e;
}

I have managed to fix the issue by wrapping the $this->getPDO()->commit() in $this->getPDO()->inTransaction() only commit if there is an active transaction in the driver.

try {
-    return $this->getPDO()->commit();
+    if ($this->getPDO()->inTransaction()) {
+        return $this->getPDO()->commit();
+    }
} catch (Throwable $e) {
    throw $this->mapException($e, 'COMMIT TRANSACTION');
}

It is also worth mentioning I am only getting this on php 8 it is working OK on 7.4. Don't know what the next steps are, I am happy to make a PR if your happy with the $this->getPDO()->inTransaction() fix.

from database.

Об ошибке PDOException: There is no active transaction:

Прошёл по всему стеку и выяснил, что транзакцию прерывает, например, CREATE TABLE в $pdo->execute().

Полагаю, что это связано с тем, что $pdo->beginTransaction() не срабатывает должным образом.

Похоже на то, что транзакция начинается (вызов $pdo->inTransaction() после beginTransaction() возвращает true), но при этом не выключается режим автоматической фиксации транзакции, как написано в документации.

Воспроизводится на php 8 + mysql (5.7, 8.0)

from database.

Also covered by tests in cycle/database#16

from database.