Angular 5 support about angular2-elastic-input HOT 20 CLOSED

After upgrading from Angular 4 to 5 I get this compilation error

ERROR in ./node_modules/angular2-elastic-input/src/elastic-input.module.ts Module build failed: Error: /Users/admin/Code/geovistory/client/node_modules/angular2-elastic-input/src/elastic-input.module.ts is missing from the TypeScript compilation. Please make sure it is in your tsconfig via the 'files' or 'include' property. The missing file seems to be part of a third party library. TS files in published libraries are often a sign of a badly packaged library. Please open an issue in the library repository to alert its author and ask them to package the library using the Angular Package Format (https://goo.gl/jB3GVv). at AngularCompilerPlugin.getCompiledFile (/Users/admin/Code/geovistory/client/node_modules/@ngtools/webpack/src/angular_compiler_plugin.js:653:23) at plugin.done.then (/Users/admin/Code/geovistory/client/node_modules/@ngtools/webpack/src/loader.js:467:39) at process._tickCallback (internal/process/next_tick.js:103:7) @ ./node_modules/angular2-elastic-input/index.js 6:9-46 @ ./src/app/app.module.ts @ ./src/main.ts @ multi webpack-dev-server/client?http://0.0.0.0:0 ./src/main.ts

Any help is appreciated, thanks!

from angular2-elastic-input.

@spirosikmd i just run ng serve --aot or with ng build --prod

from angular2-elastic-input.

@arun-maddheshia @bartes @joschne this should be fixed! Please test and re-open this issue if it does not work!

from angular2-elastic-input.

@spirosikmd thank you, it works!

npm i angular2-elastic-input@latest --save
... solved the problem for me :-)

from angular2-elastic-input.

Thank you @bartes! Yes, I need to work on the support for angular 5!

from angular2-elastic-input.

I guess it should be super simple. Adding
export * from './src/elastic-input.directive.ts'; to index.ts should help

from angular2-elastic-input.

Hey @bartes! When I run the docs example with the latest angular I don't get an error. Everything works. How can I reproduce the issue? Does this happen in a project bootstrapped with angular-cli? Otherwise, I am not what to update and why? Thanks!

from angular2-elastic-input.

yes angular-cli ..and I guess this is a case : angular/angular-cli#8284

from angular2-elastic-input.

with a bit of configuration I guess it doesn't require a change, but angular dependency has to be somehow untied. not sure

from angular2-elastic-input.

Thank you for the effort on testing with the cli. Reading through the comments in angular/angular-cli#8284, I think this is indeed a cli configuration issue. What do you mean by angular dependency has to be somehow untied?

from angular2-elastic-input.

currently it loads angular4 from within this package and I would like to have it picked up from my project.

from angular2-elastic-input.

@spirosikmd any update on it ?

from angular2-elastic-input.

@arun-maddheshia and @joschne I will look into the Angular Package format and try to update library accordingly! Expect a PR soon! Thank you for updating this issue 👍

from angular2-elastic-input.

yes please its make our life easy.

from angular2-elastic-input.

There is an issue currently with the semantic release. When this is fixed, there will be a new version!

from angular2-elastic-input.

There is a new version 1.4.0, which fixes this issue. Please try it out and let me know if it works!

from angular2-elastic-input.

@spirosikmd getting error at production build or with --aot

ERROR in Error during template compile of 'UsersModule'
  Function calls are not supported in decorators but 'ElasticInputModule' was called.

from angular2-elastic-input.

@arun-maddheshia can you please provide a bit more information? What do you mean by production build? When I run ng build in the test project that uses angular2-elastic-input everything is working. Also, how do you use --aot? How can I reproduce it? Thanks!

from angular2-elastic-input.

@spirosikmd any update?

from angular2-elastic-input.

Hey @arun-maddheshia! Not yet... I am not sure I will have time the following week to work on this issue. The only thing that is not working is AOT. But I guess this is an important feature to support. Please feel free to try and fix and submit a PR. I would much appreciate it!

from angular2-elastic-input.