Comments (5)
@Anticom can be Xenial has bumped version from 1.0.4 to 1.1.2, so it's possible.
Will check it later.
Also you can try change set(Log4Cplus_USE_STATIC_LIBS 1)
to set(Log4Cplus_USE_STATIC_LIBS 0)
in pion's CMakeLists.txt here https://github.com/splunk/pion/blob/develop/CMakeLists.txt#L119
It also can help you.
from pion.
@snikulov Indeed the version on my machine is 1.1.2. However I've looked at your FindLog4cplus.cmake and i don't see how this module is breaking anything on my machine. However Log4Cplus_USE_STATIC_LIBS
being set to 1 by default looks like causing the issue for me.
Shouldn't find_path
handle this on its own? Either way IMO it should be an option so the user has control over it.
from pion.
Shouldn't find_path handle this on its own?
- Nop.
It specific for library authors. One adds S
prefix, other add -static
. No unified way.
Just remove Log4Cplus_USE_STATIC_LIBS
at all from pion's CMakeLists.txt .
Then module will search dynamic by default, unless you explicitly not set it using -D
from pion.
Since we're building pion using Yocto i'd have to create a patch for this which would be unfortunate for such a trivial change. Is there any reason to not make it an option - besides eventually breaking working builds that use a static version of log4cplus - ?
If this is your only concern I'd vote for this "breaking" change.
from pion.
I think it is smaller then add option and use this option later.
Just remove one line and you'll give this option for user.
from pion.
Related Issues (20)
- Add a clang-format file and document approved clang-format version
- Contributors agreement submission form seems broken HOT 3
- Add support for HTTP2 HOT 1
- Quoted boundaries doesn't work
- Win32 : LNK2001 HOT 1
- Multiple COOKIE headers are not allowed by RFC 6265
- Mismatch between finished_handler_t and the actual handler function
- Another pion release including bugfixes from HEAD from the last months?
- Service headers are not getting installed when built using CMake
- Allow *some* access to currently registered resources
- Compilation issue in pion/include/pion/tcp/connection.hpp
- Ability to disable OpenSSL support (CMake)
- libpion.so dependency on boost test framework HOT 2
- Feature Request:(?) overload writer::send_chunk(void) HOT 1
- Support boost 1.66 HOT 3
- configure: error: Unable to link with the boost::unit_test_framework library HOT 3
- pion.http.server logger name does not work with log4cplus HOT 1
- compiling and running with boost 1.70.0 HOT 5
- Code and Roadmap for PION HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pion.