False Positive about discuss HOT 5 CLOSED

Thanks for following up on this. This was user error. I didn't have time to push a test project until now. It looks like it was throwing errors because the Object declaration inside the try block. The confusing thing for me was searching on stack overflow and finding many posts discussing the need to nested try finally blocks.

This change shows the user error that caused spotbugs to report the error: https://github.com/gardner/spotbugs-sandbox/pull/1/files

from discuss.

Is this code compilable? stmt is declared in try block then it cannot be referred in finally block in theory...

from discuss.

Thanks for your question. This code compiles and, by the nature of the java language constructs in use, it definitely does what the findbugs error says it may not do.

from discuss.

I'm sure that your code is not compilable, at least following code cannot be compiled:

public class A {
    public void thing1() {
        try {
            Object obj = new Object();
        } finally {
            obj.hashCode();
        }
    }
}

You have another stmt in your code, maybe it's field of your class or its ancestor, I guess.

from discuss.

Let me close this issue. Feel free to reopen.

from discuss.