Giter VIP home page Giter VIP logo

Comments (20)

hazendaz avatar hazendaz commented on September 24, 2024 1

version 3.1.3 has been released, can you please give that a try and see if it solves the problem?

from spotbugs-maven-plugin.

hazendaz avatar hazendaz commented on September 24, 2024

@romani based on that commit there is probably no real good reason to stick on the maven core 3.5.2. I need to go back though and confirm why I did that to start with. This issue has been noted now a couple of times. I'm guessing this might have had something to do with jdk9 compatibility but need to go back over my tracks on that. If it is as simple as backing that out and there are no other related issues, I can go ahead and back that out.

from spotbugs-maven-plugin.

hazendaz avatar hazendaz commented on September 24, 2024

@romani It does not appear that I did that due to any specific need other than aligning all maven usage on 3.5.2. Are you able to test against snapshots? I'd like to get a confirmation this solves the backwards compatibility issues before I cut a release.

from spotbugs-maven-plugin.

romani avatar romani commented on September 24, 2024

Are you able to test against snapshots?

I have problems to reproduce a problem on my local, it hapens on only on remote CIs. But build is easy to update to use snapshot - just change a version and run "mvn verify"

from spotbugs-maven-plugin.

hazendaz avatar hazendaz commented on September 24, 2024

I've got a test working back to maven 3.1.1. It's harder to go any further base so I'm going to make that the minimum allowed with spotbugs then I'll push a release either later tonight or sometime tomorrow.

from spotbugs-maven-plugin.

hazendaz avatar hazendaz commented on September 24, 2024

Version 3.1.2 released fixing this issue.

from spotbugs-maven-plugin.

romani avatar romani commented on September 24, 2024

hmm, It does not help, see logs at failed CIs: checkstyle/checkstyle#5540

from spotbugs-maven-plugin.

lpapazow avatar lpapazow commented on September 24, 2024

The new release didn't solve the issue for me either.

I started checking out older commits and I found that this issue starts after this commit .
Changing the mavenVersion property in the pom from 3.5.2 to 3.5.0 in the latest commit worked for me though.

My maven version is: 3.3.9

from spotbugs-maven-plugin.

hazendaz avatar hazendaz commented on September 24, 2024

from spotbugs-maven-plugin.

romani avatar romani commented on September 24, 2024

@hazendaz , does it make sense to reopen issue ?

from spotbugs-maven-plugin.

hazendaz avatar hazendaz commented on September 24, 2024

@romani
Can you give me a bit more insight into the error you had? All I could see was one failure and that did not look applicible to this plugin but rather something with the install plugin.

@lpapazow What error did you get?

from spotbugs-maven-plugin.

romani avatar romani commented on September 24, 2024

Can you give me a bit more insight into the error you had?

do you need full log ? or .... let me know details you need.

from spotbugs-maven-plugin.

hazendaz avatar hazendaz commented on September 24, 2024

Just details will help. I couldn't see everything and the only one I could looked like the install plugin had issues. Was the issue different from the one you originally experienced? I have a few ideas on how I might deal with issue such as making maven provided scope instead but not sure that will work but something I'm going to try. The idea being that maybe that might make it work on prior versions or new version since the libraries are present. But first, I'm trying to determine how I can test and get the failure.

from spotbugs-maven-plugin.

romani avatar romani commented on September 24, 2024

I created new PR, to regenerate logs, I will copy them for you in gist for review.
I still can not reproduce problem on my local, so I have failures only on remotes.

Was the issue different from the one you originally experienced?

the same.

from spotbugs-maven-plugin.

hazendaz avatar hazendaz commented on September 24, 2024

Same issue I have. Thanks!

from spotbugs-maven-plugin.

lpapazow avatar lpapazow commented on September 24, 2024

I get the same error. I can upload the full error log in a gist if you think it could help.

from spotbugs-maven-plugin.

romani avatar romani commented on September 24, 2024

diff for checkstyle project:

-    <maven.spotbugs.plugin.version>3.1.0-RC8</maven.spotbugs.plugin.version>
+    <maven.spotbugs.plugin.version>3.1.1</maven.spotbugs.plugin.version>

full build logs:
distelli - https://gist.github.com/romani/1b0f4954bc659179afe70f4afde4c33b
circle - https://gist.github.com/romani/ea5864b13a3cba2ff43e34b3abda76ba
teamcity - https://gist.github.com/romani/f56b79d6e394b7efe3110dac644005d8

from spotbugs-maven-plugin.

romani avatar romani commented on September 24, 2024

new PR is created - checkstyle/checkstyle#5579

from spotbugs-maven-plugin.

romani avatar romani commented on September 24, 2024

it works for our CI, thanks a lot.

from spotbugs-maven-plugin.

hazendaz avatar hazendaz commented on September 24, 2024

from spotbugs-maven-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.