annoy compilation fail about annoy HOT 11 CLOSED

Hm, no idea what's going on. Seems like the compilation issue could be fixed by adding "this->" in a couple of places. I will fix that and push a new version.

But it's still weird that the unit tests fail. Maybe it's an alignment problem on a specific processor? I think @a1k0n pointed out at some point there could be issues if the offset of a node isn't on a multiple of 4 or 8 on some architectures. I wonder if removing the "packed" attribute would help.

from annoy.

Pushed a fix for the compilation issues, and put the packed structs behind a macro. Would be super helpful if you can try to compile using -DNO_PACKED_STRUCTS and see if the unit tests are still failing.

from annoy.

Compilation OK now, thanks!

But tests still fail, in the same way. I'm thinking these two were unrelated issues.

Not sure where to look for problems. Seems like a big in-your-face failure => easier to debug, but I don't have time for that and Amazon is billing me per hour :(

I can still try some quick debugging if you have any suggestions where to look.

from annoy.

Background: I decided to run all the shootout tests from scratch, on a "reproducible" machine = EC2.

Annoy was returning rubbish accuracies so I dug down, found out it's nothing to do with the corpus, as the same thing happens with arbitrary data and even with the annoy's unit tests.

from annoy.

Yeah I'm pretty sure those two issues were unrelated.

I ran it on a micro instance on EC2 and the unit tests succeed so I'm not sure what's going wrong. I might try to set up an beefy EC2 instance and try later. If it's broken I'll try with -DNO_PACKED_STRUCTS to see if that resolves the issue

from annoy.

I forgot to say I tried -DNO_PACKED_STRUCTS as well :)

from annoy.

Downgraded gcc and g++ to version 4.6 => all good, tests pass now. No special compile defines needed.

I still don't know what exactly the problem was, but feel free to close this issue if you wish. Annoy works for me again.

from annoy.

I assume you didn't use windows right? Looks like something changed in 4.7: http://www.bttr-software.de/forum/mix_entry.php?id=11767

from annoy.

Yeah, I assumed it must be something compiler-specific, since Annoy has always worked for me with "older" machines (=older package versions). That's why I tried downgrading!

(OS info is in the first post; haven't tried on Windows)

from annoy.

See #24

from annoy.

Compilation issues were fixed a long time ago – the unit test issues were fixed in #24

from annoy.