Giter VIP home page Giter VIP logo

Comments (3)

damianlegawiec avatar damianlegawiec commented on June 5, 2024 1

All of these were fixed in v4.8!

from spree.

rafalcymerys avatar rafalcymerys commented on June 5, 2024

Hi @fdocr - that's correct, they were defined for backwards compatibility reasons. We didn't remove these aliases in 4.7, as we didn't want to introduce unnecessary breaking changes that would affect users' codebases. That said, I think the next version of Spree would be a good moment to sort this out :)

These deprecations not a problem at this moment, and such warnings can be suppressed in Rails configuration if they cause too much noise in the logs.

As for the solution - I'm leaning towards removing the aliases. I was planning to go through the aliased attributes one by one and verify if they're used in any meaningful way in both spree and spree-contrib repos. Given that the aliases are quite simple, I think anyone relying on them in their custom code should also be able to easily upgrade.

from spree.

fdocr avatar fdocr commented on June 5, 2024

That's great to hear @rafalcymerys, thank you for clarifying!

from spree.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.