Comments (3)
All of these were fixed in v4.8!
from spree.
Hi @fdocr - that's correct, they were defined for backwards compatibility reasons. We didn't remove these aliases in 4.7, as we didn't want to introduce unnecessary breaking changes that would affect users' codebases. That said, I think the next version of Spree would be a good moment to sort this out :)
These deprecations not a problem at this moment, and such warnings can be suppressed in Rails configuration if they cause too much noise in the logs.
As for the solution - I'm leaning towards removing the aliases. I was planning to go through the aliased attributes one by one and verify if they're used in any meaningful way in both spree and spree-contrib repos. Given that the aliases are quite simple, I think anyone relying on them in their custom code should also be able to easily upgrade.
from spree.
That's great to hear @rafalcymerys, thank you for clarifying!
from spree.
Related Issues (20)
- Support next.js commerce v2? HOT 2
- Support Rails 7.1
- Create the admin user failed HOT 2
- Spree order checkout state reload issue HOT 2
- Unable to capture payment
- Unable to add it to a fresh new rails app HOT 1
- Help to compare Spree with other shopping cart software
- DEPRECATION WARNING: `currency` is deprecated. HOT 2
- Ability to select pre-orderable options without needing variants and pricing per option value
- NameError: undefined local variable or method `try_spree_current_user' HOT 5
- Same Taxonomies in different stores HOT 10
- Facing issue due to vendor association in orders HOT 1
- Issue on docs
- Product listing showing color options
- No such file or directory - bundle
- Translation error after updating from 4.7 to 4.8.1 HOT 9
- Edit taxonomy error HOT 1
- Create taxonomy error HOT 1
- Taxon translations permalink not unique
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spree.