Comments (5)
The simplest way to achieve this is introducing a new class CloudFoundryAppDeployerOperations
that contains all the functionality needed by both the blocking and non-blocking interface.
from spring-cloud-app-broker.
I don't think it is feasible to introduce Reactive versions of the existing S-C-Deployer implementations without the risk of breaking other consumers. This is because a lot of functionality is with an abstract base class
I tried introducing a shared operations class that could be used by both reactive and non-reactive implementations. This quickly started falling apart because a lot of the functionality that would need to be shared via composition exists in the abstract class.
I think it is reasonable to not use Reactor directly to begin with, instead using deployer with an ExecutorService
when parallel deployments are required
from spring-cloud-app-broker.
Maybe I wrote this off too early..
There was another discussion about this some time age spring-cloud/spring-cloud-deployer#19
I think my fears about changing the abstract base class could be rectified by removing it completely and replacing with delegate. Would be good to discuss @royclarkson @scottfrederick
from spring-cloud-app-broker.
@royclarkson Do you think it would be possible to remove the .block()
call here: https://github.com/spring-cloud/spring-cloud-deployer-cloudfoundry/blob/master/src/main/java/org/springframework/cloud/deployer/spi/cloudfoundry/CloudFoundryAppDeployer.java#L101-L104
from spring-cloud-app-broker.
We can certainly improve that code if we are returning reactive types. IIUC, blocking there was because they wanted the exception thrown. If you are working with imperative expectations, then blocking might be the best option. I'd have to get it loaded up in an IDE and play with it to confirm.
from spring-cloud-app-broker.
Related Issues (20)
- Release App Broker 1.3.1
- Release App Broker 1.1.2
- Add source branch in staging branch during release
- Bump to Spring Boot 2.6 HOT 1
- Bump spring-cloud-open-service-broker to 3.5.x
- `AppDeploymentUpdateServiceInstanceWorkflow` is trying to update a service-instances without backing application or backing service.
- Update App Broker to Spring Boot 3.0 HOT 3
- Can this project be set under Open Service Broker ? HOT 2
- Upgrade docs to asciidoctor HOT 5
- Service instances race condition
- Fix non-resolvable dependencies in builds HOT 1
- create routes with empty host-names to enable use of private shared domains
- Add target branch to dependabot PR title HOT 3
- Cleanup superfluous dependabot configurations
- Unify Spring Boot configuration in a single point HOT 1
- Documentation build failing in v1.6.x, v1.5.x and v1.4.x
- Docs build simplification
- Invalid Spring Boot Dependabot PRs
- Support 'stack' as a configurable app parameter
- Links to Reference Docs return 404 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spring-cloud-app-broker.