Giter VIP home page Giter VIP logo

Comments (3)

spencergibb avatar spencergibb commented on May 15, 2024

the pattern doesn't match. How did you test it?

from spring-cloud-gateway.

naivefun avatar naivefun commented on May 15, 2024

I added test into RoutePredicatesTest and it passes:

@Test
public void testHostPredicates() {
	assertThat(host("**").test(mockHostExchange("test.abc.com"))).isTrue();
	assertThat(host("**.abc.**").test(mockHostExchange("test.abc.com"))).isTrue();
	assertThat(host("**.co?").test(mockHostExchange("test.abc.com"))).isTrue();
	assertThat(host("**.co").test(mockHostExchange("test.abc.com"))).isFalse();
	assertThat(host("**.abc.org:*").test(mockHostExchange("www.abc.org:8080"))).isTrue();
	assertThat(host("**.abc.org").test(mockHostExchange("www.abc.org:8080"))).isFalse();
}

I believe that the Host is parsed with port so this is fine. But if there is PortPredicates it makes sense as well?

from spring-cloud-gateway.

spencergibb avatar spencergibb commented on May 15, 2024

I think this is working properly.

from spring-cloud-gateway.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.