Comments (6)
I am a big fan of @jonatan-ivanov and I agree with him, I think the community should open issues if they have concerns about anything.
However in this case I still do not see how using the same port as Eureka is a "bug". I could easily choose another port but there could be some other application else where that uses that port...so we could be in the same situation.
Unless you can show an example of how using the same port is causing an issue or is keeping you from implementing a use case/solution I don't think there is a need to change it.
from spring-cloud-kubernetes.
I can understand that since you chose to do this, you would prefer it the same way. I wonder if anyone else in reflection thinks similar to me, that it is a needless opportunity for conflict. If someone wants to migrate from eureka to this, there will be an unnecessary conflict while that migration is occurring. That said, I won't try to help anyone do that, so indeed I'll leave it to an end user and/or stack overflow.
Y'all can choose to close this, as I feel heard even if don't agree still, as no new information was provided that would make this a better choice than it was when I opened it.
from spring-cloud-kubernetes.
I don't see where the "conflict" will occur.
from spring-cloud-kubernetes.
conflict is there if there's one pod for discovery, right?
a pod includes eureka and discoveryserver, you want to transition some applications to the discoveryserver while others haven't moved yet.
This is generally why people don't choose the same port as well established servers, for unrelated servers. Like I wouldn't choose consul's port for eureka, etc. there's no chance of conflict so you don't need to think through things like this. Choosing the same port makes this stuff possible.
from spring-cloud-kubernetes.
But this only would happen if you are running eureka and the discovery server in the same container, which begs the use case as to why you would do that?
from spring-cloud-kubernetes.
I think we are going around in circles
- why would you choose the same port as an established thing
- why would you deploy something in the way it can conflict with an established thing
I see in spring docs, notes some times about "avoid doing X" that's a solution. Another is to eliminate the problem. I'm for the latter as it is simpler (to not have the problem). If keeping this issue open means endless circles on the same points with no new information, I'll just close it. Someone else can open it, but I don't want to spend more time explaining this. No offense, just this is a time budget thing and I think there's diminishing returns at this point.
from spring-cloud-kubernetes.
Related Issues (20)
- Properly document the differences and incompatibilities between Fabric8 and Kubernetes Client
- Configmap and application in other namespace then Spring Cloud Kubernetes Configuration Watcher HOT 15
- Spring Cloud Kubernetes Configuration Watcher issue with two namespaces HOT 4
- Fabric8ProfileEnvironmentPostProcessor can freeze tests HOT 4
- spring-cloud-kubernetes version that support java 8 HOT 4
- It should discover new replicas HOT 7
- discoveryserver: readiness probe shouldn't pass when permissions are incorrect HOT 11
- discoveryserver: endpoints are inconsistent: /apps/{name}, but /app/{name}/{instanceId} HOT 3
- Spring Cloud Kubernetes - Use Informers instead of Watchers
- In rare scenarios ConfigMap update is not updated using polling strategy HOT 9
- load balancer SERVICE implementation HOT 1
- support running Fabric8IstioIT with colima HOT 7
- Future status of the `PropertySource Reload` feature HOT 1
- Importing kubernetes: config doesn't work as document with YAML config HOT 4
- config server default profile issue HOT 5
- User "system:serviceaccount:default:mockup" cannot list resource "services" in API group "" in the namespace "default" HOT 7
- Cannot find service - SERVICE_UNAVAILABLE HOT 17
- Dependency convergence fails for spring-cloud-starter-kubernetes-client-config ver 3.1.1 HOT 5
- [els.V1Service-1] i.k.c.informer.cache ReflectorRunnable : class io.kubernetes.client.openapi.models.V1Service#Reflector loop failed unexpectedly HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spring-cloud-kubernetes.