Giter VIP home page Giter VIP logo

Comments (6)

ryanjbaxter avatar ryanjbaxter commented on August 16, 2024

I am a big fan of @jonatan-ivanov and I agree with him, I think the community should open issues if they have concerns about anything.

However in this case I still do not see how using the same port as Eureka is a "bug". I could easily choose another port but there could be some other application else where that uses that port...so we could be in the same situation.

Unless you can show an example of how using the same port is causing an issue or is keeping you from implementing a use case/solution I don't think there is a need to change it.

from spring-cloud-kubernetes.

codefromthecrypt avatar codefromthecrypt commented on August 16, 2024

I can understand that since you chose to do this, you would prefer it the same way. I wonder if anyone else in reflection thinks similar to me, that it is a needless opportunity for conflict. If someone wants to migrate from eureka to this, there will be an unnecessary conflict while that migration is occurring. That said, I won't try to help anyone do that, so indeed I'll leave it to an end user and/or stack overflow.

Y'all can choose to close this, as I feel heard even if don't agree still, as no new information was provided that would make this a better choice than it was when I opened it.

from spring-cloud-kubernetes.

ryanjbaxter avatar ryanjbaxter commented on August 16, 2024

I don't see where the "conflict" will occur.

from spring-cloud-kubernetes.

codefromthecrypt avatar codefromthecrypt commented on August 16, 2024

conflict is there if there's one pod for discovery, right?

a pod includes eureka and discoveryserver, you want to transition some applications to the discoveryserver while others haven't moved yet.

This is generally why people don't choose the same port as well established servers, for unrelated servers. Like I wouldn't choose consul's port for eureka, etc. there's no chance of conflict so you don't need to think through things like this. Choosing the same port makes this stuff possible.

from spring-cloud-kubernetes.

ryanjbaxter avatar ryanjbaxter commented on August 16, 2024

But this only would happen if you are running eureka and the discovery server in the same container, which begs the use case as to why you would do that?

from spring-cloud-kubernetes.

codefromthecrypt avatar codefromthecrypt commented on August 16, 2024

I think we are going around in circles

  • why would you choose the same port as an established thing
  • why would you deploy something in the way it can conflict with an established thing

I see in spring docs, notes some times about "avoid doing X" that's a solution. Another is to eliminate the problem. I'm for the latter as it is simpler (to not have the problem). If keeping this issue open means endless circles on the same points with no new information, I'll just close it. Someone else can open it, but I don't want to spend more time explaining this. No offense, just this is a time budget thing and I think there's diminishing returns at this point.

from spring-cloud-kubernetes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.