Comments (9)
Because if we want to customize only one argument then we don't have to deal with and research internal mechanisms for table prefix
I mean I think it makes sense to assume that as long as you don't pass the tablePrefix as argument, you want to benefit from the default properties mechanism
Think somebody that just wants to pass a custom datasource, then he performs
public CustomTaskConfigurer(@BatchDataSource DataSource dataSource) {
super(dataSource);
}
But then he realises that the tables are being created in another place (when using latest SpringBoot3-enabled SCDF, for instance), he or she needs to research the implementation and understand that you need to reproduce the previous default
public CustomTaskConfigurer(@BatchDataSource DataSource dataSource, TaskProperties taskProperties) {
super(dataSource, taskProperties.getTablePrefix(), null);
}
It's an undersirable side-effect, because you are extending DefaultTaskConfigurer, so everything yoo don't explicitly touch, should remain as the Default configuration according to the name
Indeed ideally IMO it should be something like
(@EnabledConfigurationProperties TaskProperties) ? taskProperties.getTablePrefix() : DEFAULT_TABLE_PREFIX
from spring-cloud-task.
Thank you for the comment and good catch on the javax
.
But, I'm a little confused, as to why we'd want to pass in the TaskProperties to obtain the prefix when other constructors allow for the setting of the prefix?
from spring-cloud-task.
Related Issues (20)
- Composed Task - Error: 1364-HY000: Field 'CREATE_TIME' doesn't have a default value, individual tasks are working fine HOT 2
- Composed Task Launch arguments - Launch failed HOT 1
- Docs state that EPUBs are produced, but this doc type is no longer produced
- README for Timestamp sample has incorrect name for Spring Cloud Task HOT 1
- Property highlight not not properly rendered in doc HOT 2
- Link to BatchStatus doc points to 4.0.x it should refer to current release HOT 2
- misprint in spring-cloud-task 4.1.0-M2 release HOT 2
- NoSuchMethodError when launch a spring batch worker using DeployerPartitionerHandler on KubernetesDeloyerTaskLaucher HOT 3
- Update link to snapshot documentation HOT 1
- BOOT3 tables not used HOT 2
- use spring.cloud.task.tablePrefix for DefaultTaskConfigurer HOT 2
- Jar versions in the Single Step Batch Job sample readme are out of date HOT 2
- Task observability interferes with task execution listener implementations that also implement the ApplicationRunner interface HOT 2
- Auto-configuration fails when batch enabled and fail-on-job-failure is set HOT 1
- parentExecutionId is null HOT 2
- The documentation references old initializr and needs to be updated to avoid confusion. HOT 1
- Fix "รผber-jar" to "Uber-jar" in "getting-started" Documentation.
- Improve documentation on Batch - Task integration, especially regarding datasource and transactionManagers
- Set exit code is not working HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spring-cloud-task.