NullPointerException in Message.toString() method when BasicProperties are sent as null [AMQP-38] about spring-amqp HOT 7 CLOSED

Mark Fisher commented

I'm fixing this to avoid the NPE. However, it does look like you are calling getBodyContentAsString on the Message yourself? If that Message has no Content-Type header, then getBodyContentAsString() will return null (even after this fix). Can you describe what you would expect?

from spring-amqp.

Andrey Paramonov commented

My onMessage method is pretty simple:

public void onMessage(Message message) {
System.out.println("Received message: " + message);
}

getBodyContentAsString() is called from within toString() method.

Interestingly, although I send null BasicProperties, the messageProperties field in the received Message is not null, but all properties in this object are null:

#contentHeader<basic>(content-type=null, content-encoding=null, headers={}, delivery-mode=null, priority=null, correlation-id=null, reply-to=null, expiration=null, message-id=null, timestamp=null, type=null, user-id=null, app-id=null, cluster-id=null)

In that case I would expect that Message.toString() method return something like this:

Message(headers = {content-type=null, content-encoding=null, headers={}, delivery-mode=null, priority=null, correlation-id=null, reply-to=null, expiration=null, message-id=null, timestamp=null, type=null, user-id=null, app-id=null, cluster-id=null}, payload = {...})

from spring-amqp.

Mark Fisher commented

Okay. The recent commit should at least prevent the NPE. However, if the content-type header is indeed null, it would display a null body which is misleading. I think we need to create a separate issue (since this one is technically "fixed") for improving the toString() method on our Message class.

from spring-amqp.

Mark Fisher commented

I made another update. Now the toString() result of any non-null body will at least be called in the Message's own toString(). If you build from trunk, you should see output similar to what you described in the above comment.

from spring-amqp.

Andrey Paramonov commented

It did fix the original error, although now it's NPE in RabbitMessageProperties:

java.lang.NullPointerException
at org.springframework.amqp.rabbit.core.RabbitMessageProperties.getDeliveryMode(RabbitMessageProperties.java:308)
at org.springframework.amqp.core.Message.toString(Message.java:63)

from spring-amqp.

Mark Fisher commented

I added a null-check for deliveryMode, so that should no longer be a problem (on trunk).

from spring-amqp.

Andrey Paramonov commented

It works perfect now. Thank you Mark.

from spring-amqp.