Comments (3)
Well the assumption is/was that when using a header you should always have the same amount of columns for all the rows. But maybe we should take a different approach on this and differentiate between using a header and not using a header. (Maybe even add some validation).
Agree on using the number of rows from the row that actually contains the header, I guess that was an omission when creating/refactoring this class.
Ofcourse pull requests are welcomed :).
from spring-batch-extensions.
I looked into this again today.
But I am not sure on how to implement this.
I would like to only read the number of columns from the header row if a RowNumberColumnNameExtractor
was set.
But the number of columns is read from the Sheet and the sheet does not know about the column name extractor because it is set on the AbstractExcelItemReader
.
Should I just add a property like headerRowNumber
on the AbstractExcelItemReader
and the propagade it through to the Sheets getNumberOfColumns()
?
from spring-batch-extensions.
I did a fix for this, but that was still on my computer which got stolen yesterday :(.
The sheet should always use the column count of the row it is reading.
from spring-batch-extensions.
Related Issues (20)
- Upgrade maven-compiler-plugin to 3.10.1
- Upgrade surefire/failsafe to version 3.0.0-M7
- Upgrade checkstyle plugin to 3.2.0
- Upgrade Maven Javadoc Plugin to 3.4.1
- Downgrade Checkstyle to version 9.3
- Upgrade to Spring Batch 5 HOT 5
- Multithread with specific chunk size the reader distributes duplicates records across threads HOT 2
- startStatement() should not be required in Neo4jItemReader HOT 1
- Read columns as arrays HOT 4
- getColumnNames(Sheet sheet) → UnsupportedOperationException: Getting row by index not supported when streaming. HOT 1
- IsoFormattingDateDataFormatter does not work HOT 4
- Support customization of FormulaEvaluator in PoiSheet
- Date format when reading HOT 3
- Issue with spring-batch-excel using Resource which might not have getFile() implemented and does not throw a FileNotFoundException exception HOT 4
- Publish Spring Batch Excel 0.1.1 artifacts to maven HOT 3
- Upgrade to Spring Batch 4.3.5
- Need of reading one particular sheet. HOT 3
- AbstractExcelItemReader ignores a number of empty rows inbetween filled set of rows.It would help if the this functioning is made configurable since this causes incorrect meta data provided for the row number. HOT 2
- Not able to open excel files larger than 10MB HOT 6
- When extracting data from the RowSet (rs) year in date cell is shortened HOT 20
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spring-batch-extensions.