Giter VIP home page Giter VIP logo

Comments (7)

codelirium avatar codelirium commented on May 8, 2024

Hello mdeinum,

Have a look @ #14

I think there is one more state variable that needs resetting plus I updated the unit tests.

Kindest regards,
Stavros Lekkas (@codelirium)

from spring-batch-extensions.

codelirium avatar codelirium commented on May 8, 2024

Hello @mminella, would that be possible to review and merge #14 ?

from spring-batch-extensions.

mminella avatar mminella commented on May 8, 2024

Why is doing this via a new instance using step scope not good enough? I ask since that's the way just about every other reader works...

from spring-batch-extensions.

codelirium avatar codelirium commented on May 8, 2024

I might sound weird to you but:

  1. I thought reusing the same reader adds up to flexibility.
  2. I did not want to create a separate reader bean tight to every additional pass I want to make to the excel file - in cases where more than one additional passes are required.

from spring-batch-extensions.

mminella avatar mminella commented on May 8, 2024

Do you have an example of where this approach is preferred than the step one I'm proposing?

from spring-batch-extensions.

codelirium avatar codelirium commented on May 8, 2024

I am afraid I do not. I just felt reusing the reader in the product I rolled out last month.

from spring-batch-extensions.

mdeinum avatar mdeinum commented on May 8, 2024

Fixed in #65.

from spring-batch-extensions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.