Giter VIP home page Giter VIP logo

Comments (2)

odrotbohm avatar odrotbohm commented on June 3, 2024

I guess the problem here is that a MultipartFile is directly backed by the input stream of the incoming request, which in turn is tied to the thread receiving it. Any chance you copy the content into a separate data structure first?

Just to make sure: it's not obvious from the code you showed what exactly happens to the MultipartImage within ProductFile. You just state “it is empty” without clarifying what “it” refers to.

Finally, the code in the listener looks a bit suspicious. Application module listeners are intended to react to completed units of work in a foreign model. They are not intended to re-implement a request/response via events. In other words, we recommend the original business transaction to result in a valid state and the events solely transferring pointers to that state.

from spring-modulith.

eynoc-coder avatar eynoc-coder commented on June 3, 2024

I guess the problem here is that a MultipartFile is directly backed by the input stream of the incoming request, which in turn is tied to the thread receiving it. Is there any chance you could copy the content into a separate data structure first?

This assumption is true. When passing a MultipartFile in the module listeners, it seems like the binary content of the MultipartFile is wiped out. That’s why I say it is empty upon reception.

Finally, the code in the listener looks a bit suspicious. Application module listeners are intended to react to completed units of work in a foreign model. They are not intended to re-implement a request/response via events. In other words, we recommend that the original business transaction results in a valid state and that the events solely transfer pointers to that state.

You’re also right here. After posting my issue, I reread DDD by Eric Evans and realized that I missed that point, each events should be propagate when the unit of work is completed. Thanks for your feedback.

from spring-modulith.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.