Giter VIP home page Giter VIP logo

Comments (5)

GabiAxel avatar GabiAxel commented on May 27, 2024

I welcome contributions. Fork the project, add support for G+ domains and submit a pull request. Please follow Spring's code style guidelines and write Javadoc and unit tests like the rest of the project. I suggest you create a "domains" package under "plus" and add your new content to it.

from spring-social-google.

nodoze avatar nodoze commented on May 27, 2024

Thanks. I will give it a spin as time permits. Have you thought about integrating the google library to use their binding?

Sent from my iPad

On Sep 6, 2014, at 3:46 AM, Gabriel Axel [email protected] wrote:

I welcome contributions. Fork the project, add support for G+ domains and submit a pull request. Please follow Spring's code style guidelines and write Javadoc and unit tests like the rest of the project. I suggest you create a "domains" package under "plus" and add your new content to it.


Reply to this email directly or view it on GitHub.

from spring-social-google.

GabiAxel avatar GabiAxel commented on May 27, 2024

That's what Google.getAccessToken() is for - you can use Spring Social Google for the authentication process and use the access token with Google's Java library or any other code that interacts with the HTTP API.

Spring Social projects (not only this one) interact directly with the HTTP APIs, and the common core allows the specific projects to get a lot of free stuff out of the box, so there isn't much sense in wrapping another library to interact with the APIs. They can co-exist in the same project just fine as mentioned above.

from spring-social-google.

nodoze avatar nodoze commented on May 27, 2024

I did some tests using the getAccessToken() approach yesterday. There are
some scope conflicts between the two APIs. Also it¹s not as clean as I¹d
like it to be since it creates competing bindings / model classes for the
same API. I¹m very familiar with most aspects of the spring framework and
very much appreciate the work the community is putting in to make free
software available to everyone. Since I¹ve been largely on the receiving
end till now I¹ve figured I would start paying back a bit. Anyway, I will
play around with and let you know how it goes.

From: Gabriel Axel [email protected]
Reply-To: GabiAxel/spring-social-google
<[email protected]
hub.com>
Date: Saturday, September 6, 2014 at 12:03 PM
To: GabiAxel/spring-social-google [email protected]
Cc: Oliver Eberle [email protected]
Subject: Re: [spring-social-google] Do you plan on adding support for Plus
Domains? (#60)

That's what Google.getAccessToken() is for - you can use Spring Social
Google for the authentication process and use the access token with Google's
Java library or any other code that interacts with the HTTP API.

Spring Social projects (not only this one) interact directly with the HTTP
APIs, and the common core allows the specific projects to get a lot of free
stuff out of the box, so there isn't much sense in wrapping another library
to interact with the APIs. They can co-exist in the same project just fine
as mentioned above.


Reply to this email directly or view it on GitHub
<#60 (comment)
24765> .

from spring-social-google.

vauvenal5 avatar vauvenal5 commented on May 27, 2024

I know this is not completely on topic but since you discussed here wrapping the Google API library I decided to continue here. The Spring Social documentation itself suggests integrating API bindings if they exist instead of writing new bindings: http://docs.spring.io/spring-social/docs/1.1.4.RELEASE/reference/htmlsingle/#integrating-an-existing-java-api-binding

So basically my question is, where is the advantage in providing another binding?

from spring-social-google.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.