Giter VIP home page Giter VIP logo

Comments (12)

nfts2me avatar nfts2me commented on June 2, 2024 8

We are not planning to add support for viem but would welcome a contribution. As this library already supports both ethers.js v5 and v6 I believe the "crypto backend" is abstracted enough to make such addition relatively easily, unless I'm missing something.

I'd say that you are missing what we believe is very important.
Quite a lot of websites use Viem/Wagmi.
And quite a lot, like us, the only usage of ethers is from this package, leading to an unnecesary increase of package downloading from the users which leads to a worse user experience, specially on smartphones / contries with slow Internet connections.

from siwe.

conwayconstar avatar conwayconstar commented on June 2, 2024 6

I created a viem version here https://github.com/feelsgoodman-web3/siwveim

from siwe.

nfts2me avatar nfts2me commented on June 2, 2024 4

It would be awesome to have viem support or directly replace ethers.

from siwe.

w4ll3 avatar w4ll3 commented on June 2, 2024 3

Hello, we are discussing how to address this, since the library went through an audit it gets a little more complicated to replace such a vital library. Hope you understand!

from siwe.

FrancoAguzzi avatar FrancoAguzzi commented on June 2, 2024 2

+1 vote to have viem support 🙏🏼

from siwe.

reslear avatar reslear commented on June 2, 2024 2

Good news wevm/viem#2280

from siwe.

conwayconstar avatar conwayconstar commented on June 2, 2024 1

Say no more!

from siwe.

reslear avatar reslear commented on June 2, 2024

in the end, we should 👍
maybe @conwayconstar create a PR?

from siwe.

reslear avatar reslear commented on June 2, 2024

So i write small lib, also welcome to testing simplified siwe with Viem 2

https://github.com/reslear/simple-siwe

Comparison

Package Install size Linting Engine Parser
simple-siwe v0.1.4 install size average Viem v2 own (beta)
eip-login v0.1.0 install size average Viem v2 -
siwviem v1.3.0 install size high Viem v1 @spruceid/siwe-parser
siwe v2.3.2 install size high ethersjs @spruceid/siwe-parser
siwe-viem v0.1.0 install size high Viem v2 @spruceid/siwe-parser

from siwe.

2facedsquid avatar 2facedsquid commented on June 2, 2024

any update on this?

from siwe.

sbihel avatar sbihel commented on June 2, 2024

We are not planning to add support for viem but would welcome a contribution. As this library already supports both ethers.js v5 and v6 I believe the "crypto backend" is abstracted enough to make such addition relatively easily, unless I'm missing something.

from siwe.

reslear avatar reslear commented on June 2, 2024

@nfts2me Yes and no, there's also a deps problem (like parsers based on apg-js), See my Comparison above packages on viem ~2mb.

however siwe 2.8mb + parser 2.66 + ethers 18.8MB = ~23mb

hence the motivation to make https://github.com/reslear/simple-siwe a scaled-down copy without dependencies

from siwe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.