Giter VIP home page Giter VIP logo

Comments (5)

dalthviz avatar dalthviz commented on September 25, 2024 2

Hi @duylp thank you for the feedback! Could you update to the latest qtpy and check again? I think we are missing bumping the constraint for qtpy to be at least >=2.0.0 at https://github.com/spyder-ide/qtawesome/blob/master/setup.py#L35

from qtawesome.

duylp avatar duylp commented on September 25, 2024 2

Thanks, I've tested it and your solution works for me.

from qtawesome.

ccordoba12 avatar ccordoba12 commented on September 25, 2024 1

What do you think @ccordoba12 ? In that way we should not need to constrain qtpy or add try-catch logic, right?

Yeah, sounds good to me.

from qtawesome.

duylp avatar duylp commented on September 25, 2024

Hi @dalthviz, thanks for solution, that should work. Reading from the changelog, I don't see any features aside from this depend on PYSIDE6. Would it be better to check if PYSIDE6 exists rather than pinning qtpy>=2.0.0?

In our usage, qtpy is pinned to be 1.x.x so we're currently pinning qtawesome.

from qtawesome.

dalthviz avatar dalthviz commented on September 25, 2024

Thanks for the info @duylp ! I see, so maybe you are still using Qt4? Checking maybe we could change the validation using qtpy.PYSIDE2 or qtpy.PYSIDE6 at

if PYSIDE2 or PYSIDE6:

to use qtpy.PYSIDE_VERSION so:

    if PYSIDE_VERSION:

What do you think @ccordoba12 ? In that way we should not need to constrain qtpy or add try-catch logic, right?

Also @duylp could you check if the change I'm suggesting works in your setup with qtpy <=1.x ? Thank you!

from qtawesome.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.