Enhancement: include better error messaging for selected date on init. about android-times-square HOT 4 CLOSED

@RussellCollins Can you elaborate? The onInvalidDateSelected toast is using this string: Date must be between %1$s and %2$s. which should show exactly what dates are being used for the bounds.

from android-times-square.

I'll have to double-check but if I recall the reason why the toast wasn't
useful was that the full Date wasn't shown (i.e. "Dec 12, 2013" vs "Dec 12
2013 00:00:00"). This meant we had a message that didn't match what we
thought we were supplying as correct inputs. In our debugging we found a
convenience method essentially called 'setDateToMidnight()" in the library
which clued us in on what you were doing. This made sense once we saw it
but was subtly different than what we inferred from the Toast. Does that
make sense? It resulted in the CalendarViewPicker being initialized with
the end date being unselectable in the view based on how we were supplying
the range. We adjusted to use logic that more closely matched what was
being done by the library and everything works great (thank you!) but the
Toast felt misleading until we understood the choices you made in setting
times to zero to fully encompass the totality of the date range.

On Sun, Jan 5, 2014 at 9:50 PM, edenman [email protected] wrote:

@RussellCollins https://github.com/RussellCollins Can you elaborate?
The onInvalidDateSelected toast is using this string: Date must be
between %1$s and %2$s. which should show exactly what dates are being
used for the bounds.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/87#issuecomment-31628958
.

from android-times-square.

Gotcha. I'm going to leave this closed: I think the comment on the init method makes it clear how the minDate and maxDate work. Sorry it bit you and thanks for using the library!

from android-times-square.

Works for me. I'll just keep this in my back pocket in case it comes up for
anyone else.
On Jan 10, 2014 11:16 AM, "edenman" [email protected] wrote:

Gotcha. I'm going to leave this closed: I think the comment on the init
method makes it clear how the minDate and maxDate work. Sorry it bit you
and thanks for using the library!

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/87#issuecomment-32056196
.

from android-times-square.