Comments (8)
The very first example in the README is a before and after example. Maybe you can sketch here what you would change?
from anvil.
I Agree, the first example is clear and easy to understand.
How I see the current way to meet with your tool:
-
Read the README. There I see parts with an explanation of:
ContributeTo
andMergeComponent
, Scopes,ContributeBindings
, Exclusions. On that step, I was thinking of how I could make exclusions only withDagger
; So I would add a part:You could make it with Dagger and how or you couldn't it's an Anvil's feature
-
I want to see all the small pieces and new concepts together. So, I will go to the
sample
directory for the final view. On that step, I want to see the sample's README with a project's overview. The overview should help me to realize: what scenarios I will see, wherein that directory I could find them -
I want to see the same sample but only in Dagger. It could be a specific branch. It will help me to compare the whole result not only different pieces
-
I, like an interested user in your tool, will look for a migration guide. Could Anvil and Dagger work together? How? What errors will I see If I make something wrong? etc.
from anvil.
You misunderstood this tool. Anvil is like an extension for Dagger in a Kotlin codebase and not a replacement. The features Anvil provides don't exist in Dagger, there doesn't need to be a comparison except for the initial example.
from anvil.
Sorry, but I got the idea of Dagger extension
for the first time when I read README. But I don't get the problems you see in my previous message. I only want to highlight that if I saw everything I described I would get the idea, scenarios of using, and migration plan faster
My message is not about something new it's about how my mind works when I investigate something. So If you don't find my ideas fit your vision it's ok. But would you give feedback on what looks strange for you?
from anvil.
Maybe it's easier when you create a PR with the changes so that I can better understand what you mean. But please don't feel discouraged or be disappointed if I won't merge the PR.
from anvil.
But please don't feel discouraged or be disappointed if I won't merge the PR
My opinion is that you as a project owner know better in common what changes your project needs.
I need only feedback from you.
So I will think about the next small step and then I will return with a proposition.
I'm happy that you are open to dialogue.
from anvil.
Closing due to inactivity.
from anvil.
Thank you for closing it. I will return in next quarter.
from anvil.
Related Issues (20)
- Configuration error in gradle-plugin when building on Windows HOT 1
- Suspend lambda parameters are not supported when generating code for AssistedInject/AssistedFactory
- Anvil seems incompatible when using with Dagger KSP HOT 2
- Couldn't resolve FqName com.google.protobuf.kotlin.ProtoDslMarker for Anvil HOT 1
- Incorrect type validation for `@Binds`
- Support KSP in factory generation HOT 14
- Incremental compilation breaks when modifying constructor properties HOT 1
- IDE not syncing on fresh pull HOT 1
- How to deal with MergeSubComponent with AndroidInjector
- Dependency Dashboard
- Question about runtime performance difference between @MergeSubcomponent and @ContributesSubcomponent HOT 2
- @Component.Factory types must be nested within a @Component HOT 1
- Ir Compile Issue Kt 1.9.21 HOT 1
- Anvil making downstream gradle kotlin compilation task not cacheable HOT 4
- Generated files contain errors HOT 2
- Add ability to generate a ContributesBinding baseline? HOT 3
- AssistedFactory generation (still) fails under IC
- Stub gen FileNotFoundException with new file tracking enabled
- Compiling annotation that does not exist throws `NoSuchElementException` HOT 2
- Strange behavior: @Binds methods' parameter type must be assignable to the return type. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from anvil.