Generated Dagger factory should respect class internal visibility about anvil HOT 4 CLOSED

Dagger is also generates Factory with public visibility and it works as kotlin internal visibility maps to Java public. Probably we just abusing interop, feel free to close this issue if no feasible solution is possible.

from anvil.

Facing exact same problem, as most of our modules encapsulate logic behind interfaces with internal implementation.

from anvil.

We have the policy internally to make all Dagger code public for this exact reason. Dagger assumes public, internal is treated as public in bytecode. The reason it doesn't fail with Dagger is because the internal code is referenced in generated Java code. Try to call an internal function from Java in a different module. You'll see an error. internal is misleading, because it implies that nothing outside of this module uses this code. That's wrong, Dagger uses and calls this code outside of the module.

There's also this issue which is important for implementation and api dependencies: google/dagger#970

The solution as is works as expected.

from anvil.

I suppose here is a discussion about this problem in dagger: google/dagger#2589

from anvil.