Giter VIP home page Giter VIP logo

Comments (3)

ZacSweers avatar ZacSweers commented on June 16, 2024

That's strange, we should be inlining the constant value, not using the import 🤔

from anvil.

RBusarow avatar RBusarow commented on June 16, 2024

Yeah, we can't just re-use the imports since they may not be visible to the generated modules. We didn't actually intend to use the imports, though -- it just looks that way.

The logic for parsing those const arguments into their raw values was just giving up too soon. As soon as it saw a String initializer for the constant ("$OTHER_CONSTANT.foo"), it would just pass that string literal as though it's the value.

So when you see this:

@StringKey(value = "$OTHER_CONSTANT.foo")

...it's not actually a property reference without an import. It's more like a String literal where we failed to escape the dollar sign.

Anyways, the fix is up: #940 :)

from anvil.

bubenheimer avatar bubenheimer commented on June 16, 2024

Thank you for the prompt fix!

from anvil.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.