Giter VIP home page Giter VIP logo

Comments (3)

mrtrkmn avatar mrtrkmn commented on May 17, 2024

Hey @alokmenghrajani
I would like to contribute to code and I saw this issue has good first task label, could you a liitle bit explain (-this issue-) how the tool behave regarding to this feature ?

Besides, I checked other issues, but seems those are not up to date, I do not know which one is done or not, there are still some issues from 2017 for instance. I think, some of the issues are overdue or completed.

from certstrap.

mcpherrinm avatar mcpherrinm commented on May 17, 2024

In a few places, we load keys in a way that assumes they are PKCS1:

https://github.com/square/certstrap/blob/master/pkix/key.go#L91

But we should also support PKCS8, via the function ParsePKCS8PrivateKey -- Probably easiest would be to just try both functions, and return if one or the other works

from certstrap.

jdtw avatar jdtw commented on May 17, 2024

This is done now:

priv, err := x509.ParsePKCS8PrivateKey(pemBlock.Bytes)

from certstrap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.